TypeError: array_flip(): Argument #1 ($array) must be of type array, null given
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Sgs
	Apr 4 2025, 11:18 AM

Description

While trying to seed some image suggestions locally I stumbled on this error.

Steps to replicate the issue (include links if applicable):

➜  w git:(master) php maintenance/run.php ./extensions/CirrusSearch/maintenance/UpdateWeightedTags.php --tagType 'recommendation.image' --page Nanocomposite --verbose

What happens?:
An error is thrown, the script cannot be used without tagName option as it was doing prior to rECIRd7c02d73ad0637c7dd4f5f06abc6b4ee542b39e5

[865069a1605512609323e693] [no req]   TypeError: array_flip(): Argument #1 ($array) must be of type array, null given
Backtrace:
from /Users/sergio/src/mediawiki/w/extensions/CirrusSearch/maintenance/UpdateWeightedTags.php(70)
#0 /Users/sergio/src/mediawiki/w/extensions/CirrusSearch/maintenance/UpdateWeightedTags.php(70): array_flip(null)
#1 /Users/sergio/src/mediawiki/w/maintenance/includes/MaintenanceRunner.php(694): CirrusSearch\Maintenance\UpdateWeightedTags->execute()
#2 /Users/sergio/src/mediawiki/w/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#3 {main}

What should have happened instead?:

The script should run without a tagName option?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	UpdateWeightedTags: make tagName mandatory	mediawiki/extensions/CirrusSearch	master	+1 -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		pfischer	T366253 Create a generic stream to populate CirrusSearch weighted_tags
Resolved		dcausse	T374702 Cleanup: Remove deprecated weighted tag methods
Resolved	BUG REPORT	dcausse	T391090 TypeError: array_flip(): Argument #1 ($array) must be of type array, null given

Event Timeline

Sgs created this task.Apr 4 2025, 11:18 AM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptApr 4 2025, 11:18 AM

Looking at the code it seems that despite tagName being optional I don't see how it can work without it... we should probably make it explicitly required. For you I suspect the correct call args should be:
--tagType 'recommendation.image' --tagName 'exists' --page Nanocomposite --verbose

dcausse renamed this task from TypeError when running UpdateWeightedTags to TypeError: array_flip(): Argument #1 ($array) must be of type array, null given.Apr 4 2025, 12:25 PM

dcausse merged a task: T391098: TypeError: array_flip(): Argument #1 ($array) must be of type array, null given.

dcausse added a subscriber: Reedy.

Gehel triaged this task as High priority.Apr 7 2025, 3:22 PM

Gehel edited projects, added Discovery-Search (2025.03.22 - 2025.04.11); removed Discovery-Search.

Gehel set the point value for this task to 1.Apr 7 2025, 3:38 PM

Gehel moved this task from Incoming to Ready for Dev on the Discovery-Search (2025.03.22 - 2025.04.11) board.

Gehel edited projects, added Discovery-Search (2025.04.11 - 2025.05.02); removed Discovery-Search (2025.03.22 - 2025.04.11).Apr 11 2025, 1:26 PM

Gehel moved this task from Incoming to Ready for Dev on the Discovery-Search (2025.04.11 - 2025.05.02) board.

Change #1136330 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] UpdateWeightedTags: make tagName mandatory

https://gerrit.wikimedia.org/r/1136330

gerritbot added a project: Patch-For-Review.Apr 14 2025, 8:54 AM