Page MenuHomePhabricator

Design: Revisit the early designs for inline display of Wikifunctions errors in Wikipedia articles
Closed, ResolvedPublic

Assigned To
Authored By
gengh
Apr 4 2025, 3:22 PM
Referenced Files
F59974903: image.png
May 14 2025, 5:02 PM
F59974899: image.png
May 14 2025, 5:02 PM
F59974908: image.png
May 14 2025, 5:02 PM
F58980821: context-popup.png
Apr 4 2025, 3:22 PM
F58980819: read-page.png
Apr 4 2025, 3:22 PM

Description

Discovery and definition

The work for T390554: Show read-mode errors from the Wikifunctions integration inline rather than in a box, so that editors can be less disrupted when something is wrong is planned based on some early inline error designs:

https://www.figma.com/design/sMOc0itmJIm6qthj8XKfMd/T363391-Design-prototype-for-WF-use-case-in-WP?node-id=474-11464&p=f&t=W4WxOtCskQltPlGr-0

Building on top of Q3 error-related work, we should finalize these designs, mostly with a couple of clarifications:

  • Function error block in read page: how to link to user page?
  • What's the final copy for the error message?

1. Read page: Link to the error documentation

The error designs don't clarify how the link to the error guide page is displayed to the user in the read pages: Is the whole inline box clickable? Should there be a link or clickable icon inside of the inline box?

read-page.png (236×512 px, 91 KB)

2. Context popup error message

The error message in the context popup is an early take. Currently the copy reads:

The function can't display a result. Edit to fix missing or invalid values. Learn more.

This message seems to assume that every error can be fixed by editing the function call. However, errors might not be fixable through VE editing.

context-popup.png (375×812 px, 128 KB)


Additional info


Completion checklist
Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Design_task_completion_checklist

Event Timeline

DSantamaria triaged this task as Medium priority.Apr 9 2025, 4:59 PM
gonyeahialam changed the task status from Open to In Progress.Apr 23 2025, 2:00 PM
gonyeahialam claimed this task.

For the inline error we would use a small version of the button component which is being worked on T352201. We would use the quiet destructive button.

Read pageVisual editor (VE)VE context pop-up
On the article page, all interaction is removed from the buttonOn VE the button is clickableClicking on the button shows the context pop-up with more details about the error and a link to learn more
image.png (750×1,624 px, 505 KB)
image.png (750×1,624 px, 483 KB)
image.png (750×1,624 px, 249 KB)

Assuming this was signed-off by the OKR driver.

Oh no it wasn't. cc @gengh