Page MenuHomePhabricator
Create Task
Maniphest T391160

Rejecting a pending change incorrectly said that it was already accepted
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

When I tried to reject a pending changes edit, I believe it stated "Cannot reject these changes because someone already accepted some (or all) of the edits.". However, the changes were rejected by someone else.

Someone at WP:VP/T suggested to file a report on PHAB as it is likely affecting other wikis (fixed on enwiki by QoH).

What should have happened instead?:
I suggest a message change to "some or all of the edits have already received a review" or something along that line.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): 1.44.0-wmf.23 (70d5344)

Other information (browser name/version, screenshots, etc.): Chrome on Windows if that matters

Related Objects

Event Timeline

Wildfireupdateman created this task.Apr 5 2025, 2:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2025, 2:20 AM
Anoop added a project: FlaggedRevs.Apr 5 2025, 5:51 AM
Aklapper added a comment.Apr 5 2025, 7:11 AM

When I tried to reject a pending changes edit,

Link welcome, otherwise it's harder to investigate.

Aklapper renamed this task from Pending Change Review issue to Rejecting a pending change incorrectly said that it was already accepted.Apr 5 2025, 7:12 AM
Pppery added a project: I18n.Apr 5 2025, 3:22 PM
Wildfireupdateman added a comment.Apr 5 2025, 4:37 PM
In T391160#10714874, @Aklapper wrote:

When I tried to reject a pending changes edit,

Link welcome, otherwise it's harder to investigate.

It should be like that for every pending change but the specific diff I noticed it was https://en.wikipedia.org/w/index.php?title=Major_League_Baseball&diff=prev&oldid=1283996055 . On Enwiki it's been locally fixed by an admin so I can't get screenshots anymore, but I'm not sure about other wikis since I don't have pending change reviewer on any other ones.

1AmNobody24 subscribed.Apr 7 2025, 1:54 PM

I think the message WFUM means comes from here. But I do wonder why that one shows, not this one.

TheDJ subscribed.Apr 8 2025, 10:11 AM

Original discussion: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#c-Redrose64-20250405085600-Wildfireupdateman-20250405033400
Message key in question: review_cannot_reject

In T391160#10717812, @1AmNobody24 wrote:

But I do wonder why that one shows and not review_conflict_oldid

Probably because a. review step does not equal an edit (revision id) change, and these errors seem to match those two different levels. The message probably is indeed incorrect and might require splitting or updating..

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits