Wiki logo for event is not displaying on event page dialog and SpecialEventDetails
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	vaughnwalters
	Apr 7 2025, 10:11 PM

Description

Steps to replicate the issue (include links if applicable):

Go to the event page dialog or Special:EventDetails for an event that selected specific wikis or all wikis for the event to appear

What happens?:
Wiki logo does not appear anymore. This bug has not made it to prod yet but is reproducible in betacluster and on local.

What should have happened instead?:
The wiki of the event logo should still be appearing.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
1.44.0-alpha (7cd0f4e)

Other information (browser name/version, screenshots, etc.):

Screenshot 2025-04-07 at 5.03.19 PM.png (1×1 px, 290 KB)

Screenshot 2025-04-07 at 5.07.45 PM.png (1×1 px, 277 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Return correct wiki icon dependant on rendering library	mediawiki/extensions/CampaignEvents	master	+53 -17

Customize query in gerrit

Revisions and Commits

rUCAM extension-CampaignEvents
	rUCAM6a41755ca1bf Revert "Convert TextWithIconWidget to Codex"
	rUCAM305fbdf7ae1c Revert "Convert TextWithIconWidget to Codex"
	rUCAM20b2631d6297 Revert "Convert TextWithIconWidget to Codex"

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		MHorsey-WMF	T385347 [EPIC] Create embeddable version of the Collaboration List
Resolved		Daimona	T388427 Make sure there are no transclusion bugs due to global state access when transcluding Special:AllEvents
Open		None	T386102 Make sure CampaignEvents special pages look reasonably OK on Monobook and Timeless
Resolved		Daimona	T388451 Convert TextWithIconWidget to Codex
Resolved	BUG REPORT	MHorsey-WMF	T391296 Wiki logo for event is not displaying on event page dialog and SpecialEventDetails

Event Timeline

vaughnwalters created this task.Apr 7 2025, 10:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2025, 10:11 PM

Wargo added a parent task: T388451: Convert TextWithIconWidget to Codex.Apr 8 2025, 10:12 AM

getWikiIcon returns Codex name now instead of OOUI name. Event details module is not converted yet.

Solutions: proceed with converting to Codex or temporary workaround in getWikiIcon.

Screenshot 2025-04-08 at 10.00.48 AM.png (1×1 px, 287 KB)

Screenshot 2025-04-08 at 10.01.32 AM.png (1×1 px, 261 KB)

This is now fixed in betacluster

vaughnwalters attached a referenced file: F59015012: Screenshot 2025-04-08 at 10.00.48 AM.png. (Show Details)Apr 8 2025, 3:04 PM

Wargo added commits: rUCAM20b2631d6297: Revert "Convert TextWithIconWidget to Codex", rUCAM305fbdf7ae1c: Revert "Convert TextWithIconWidget to Codex", rUCAM6a41755ca1bf: Revert "Convert TextWithIconWidget to Codex".Apr 8 2025, 3:39 PM

MHorsey-WMF moved this task from QA 🐛 to Ready for development on the Connection-Team (Connection-Current-Sprint) board.Apr 10 2025, 3:00 PM

MHorsey-WMF mentioned this in T388451: Convert TextWithIconWidget to Codex.

MHorsey-WMF changed the task status from Open to In Progress.Apr 14 2025, 10:10 AM

MHorsey-WMF moved this task from Ready for development to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.

Converting the textWithIconWidget to codex changed the EventFormatter code to return the correct css class for codex but the event page dialog has not been fully converted. I have reverted the patches until either the event page dialog has been fully converted to code or a fix has been implemented to work for both codex and OOUI.

MHorsey-WMF claimed this task.Apr 14 2025, 10:15 AM

the attached patch should enable us the unrevert the patches for textWithIconWidget.

In T391296#10738186, @MHorsey-WMF wrote:

the attached patch should enable us the unrevert the patches for textWithIconWidget.

Noting that there is no attached patch

Change #1136350 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Return correct icon dependant on rendering library

https://gerrit.wikimedia.org/r/1136350

Change #1136350 had a related patch set uploaded (by Daimona Eaytoy; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Return correct wiki icon dependant on rendering library

https://gerrit.wikimedia.org/r/1136350

Change #1136350 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Return correct wiki icon dependant on rendering library

https://gerrit.wikimedia.org/r/1136350

Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Apr 15 2025, 4:20 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).Apr 15 2025, 5:00 PM

VPuffetMichel added a project: Essential-Work.Apr 17 2025, 1:30 PM

In T391296#10722093, @vaughnwalters wrote:

This is now fixed in betacluster

Keeping this in QA until it is released to prod

Event page dialog	Special:EventDetails

This is fixed in prod now, marking as done / resolved.

	F59553050: Screenshot 2025-04-29 at 12.28.04 PM.png
	Apr 29 2025, 5:29 PM

	F59553001: Screenshot 2025-04-29 at 12.23.47 PM.png
	Apr 29 2025, 5:29 PM

	F59015018: Screenshot 2025-04-08 at 10.01.32 AM.png
	Apr 8 2025, 3:03 PM

	F59015012: Screenshot 2025-04-08 at 10.00.48 AM.png
	Apr 8 2025, 3:03 PM

	F59008549: Screenshot 2025-04-07 at 5.07.45 PM.png
	Apr 7 2025, 10:11 PM

	F59008543: Screenshot 2025-04-07 at 5.03.19 PM.png
	Apr 7 2025, 10:11 PM

Wiki logo for event is not displaying on event page dialog and SpecialEventDetailsClosed, ResolvedPublicBUG REPORTActions

Description

Details

Revisions and Commits

Related ObjectsSearch...

Event Timeline

Wiki logo for event is not displaying on event page dialog and SpecialEventDetails
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...