Page MenuHomePhabricator

[VE WikifunctionsCall]: Adapt function call editing to new parsoid version
Closed, ResolvedPublic

Description

Description

Now Wikifunctions calls use new Parsoid (0.21.0-a25) async fragment provision.

Adapt Visual Editor function call insertion and editing to fit the current behavior.

Acceptance criteria

When adding a new function or editing an existing one, if the fragment handler returns an async-not-ready fragment:

  • Add a dynamic loading state instead of the Pending Fragment
  • Retry every 60seconds and replace with async fragment
  • Contemplate bypassing the async fragment handler response?? (update: NOPE not necessary)

Completion checklist

Event Timeline

DSantamaria changed the task status from Open to In Progress.Apr 9 2025, 4:40 PM

Change #1136033 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Wikifunctions VE: Add loading and abort state to content editable

https://gerrit.wikimedia.org/r/1136033

Change #1136033 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Wikifunctions VE: Add loading and abort state to content editable

https://gerrit.wikimedia.org/r/1136033

Change #1136051 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.44.0-wmf.24] Wikifunctions VE: Add loading and abort state to content editable

https://gerrit.wikimedia.org/r/1136051

Change #1136051 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.44.0-wmf.24] Wikifunctions VE: Add loading and abort state to content editable

https://gerrit.wikimedia.org/r/1136051

Mentioned in SAL (#wikimedia-operations) [2025-04-14T12:06:13Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1136049|Special pages: Don't just set userCanExecute() but actually run it (T391594)]], [[gerrit:1136050|Client mode: Provide WikiLambdaClientModeOffline for SRE to disable]], [[gerrit:1136051|Wikifunctions VE: Add loading and abort state to content editable (T391441)]], [[gerrit:1136126|logging: Allow through WikiLambdaClient logs at info level and

Mentioned in SAL (#wikimedia-operations) [2025-04-14T12:36:52Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1136049|Special pages: Don't just set userCanExecute() but actually run it (T391594)]], [[gerrit:1136050|Client mode: Provide WikiLambdaClientModeOffline for SRE to disable]], [[gerrit:1136051|Wikifunctions VE: Add loading and abort state to content editable (T391441)]], [[gerrit:1136126|logging: Allow through WikiLambdaClient logs at info level and

Mentioned in SAL (#wikimedia-operations) [2025-04-14T12:44:24Z] <jforrester@deploy1003> jforrester: Backport for [[gerrit:1136049|Special pages: Don't just set userCanExecute() but actually run it (T391594)]], [[gerrit:1136050|Client mode: Provide WikiLambdaClientModeOffline for SRE to disable]], [[gerrit:1136051|Wikifunctions VE: Add loading and abort state to content editable (T391441)]], [[gerrit:1136126|logging: Allow through WikiLambdaClient logs at info level and above]] sync

Mentioned in SAL (#wikimedia-operations) [2025-04-14T12:56:20Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1136049|Special pages: Don't just set userCanExecute() but actually run it (T391594)]], [[gerrit:1136050|Client mode: Provide WikiLambdaClientModeOffline for SRE to disable]], [[gerrit:1136051|Wikifunctions VE: Add loading and abort state to content editable (T391441)]], [[gerrit:1136126|logging: Allow through WikiLambdaClient logs at info level an