Page MenuHomePhabricator
Create Task
Maniphest T391442

Create HookRunner classes and interfaces for Wikibase Client and use them
Open, Needs TriagePublic
Actions

Description

On the basis of the Wikibase Hooks ADR in T391438 and in support of T338452, create HookRunner classes and interfaces for the Wikibase Client code, and use them throughout.

This includes:

  • core hooks
  • CirrusSearch hooks
  • Echo hoooks
  • Scribunto hooks
  • Own hooks

Acceptance Criteria

  • Use of Wikibase Hooks within Wikibase Client code are conformant with the Wikibase Hooks ADR [link to be added later]

Details

SubjectRepoBranchLines +/-
Clean up hooks documentationmediawiki/extensions/Wikibasemaster+24 -34
Use HookRunner for WikibaseClientEntityTypes hookmediawiki/extensions/Wikibasemaster+50 -15
Migrate WikibaseContentLanguages hookmediawiki/extensions/Wikibasemaster+85 -10
Add configureHookRunner() to ServiceWiringTestCasemediawiki/extensions/Wikibasemaster+44 -2
Use HookRunner for WikibaseClientDataTypes hookmediawiki/extensions/Wikibasemaster+54 -15
Use HookRunner for WikibaseClientSiteLinksForItemmediawiki/extensions/Wikibasemaster+102 -68
Re-enable SpecialAboutTopicIntegrationTest::testExecution testmediawiki/extensions/ArticlePlaceholdermaster+1 -4
Temporarily disable SpecialAboutTopicIntegrationTest::testExecutionmediawiki/extensions/ArticlePlaceholdermaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ArthurTaylor created this task.Wed, Apr 9, 9:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Apr 9, 9:45 AM
ArthurTaylor updated the task description. (Show Details)Wed, Apr 9, 9:48 AM
ArthurTaylor added parent tasks: T338452: Update Wikibase to use the new HookContainer/HookRunner system, T381172: [EPIC] Update all WMDE Wikibase topics to use the new HookContainer/HookRunner system.
Maintenance_bot added a project: Wikidata.Wed, Apr 9, 10:30 AM
karapayneWMDE moved this task from Incoming to The Backlog on the Wikidata-Omega board.Wed, Apr 9, 10:51 AM
ArthurTaylor claimed this task.Fri, Apr 11, 7:09 AM
ArthurTaylor moved this task from The Backlog to The Board on the Wikidata-Omega board.
ArthurTaylor edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.
ArthurTaylor moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Fri, Apr 11, 9:16 AM

Change #1135904 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Use HookRunner for WikibaseClientSiteLinksForItem

https://gerrit.wikimedia.org/r/1135904

gerritbot added a project: Patch-For-Review.Fri, Apr 11, 9:16 AM
gerritbot added a comment.Fri, Apr 11, 9:26 AM

Change #1135907 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Use HookRunner for WikibaseClientDataTypes hook

https://gerrit.wikimedia.org/r/1135907

gerritbot added a comment.Fri, Apr 11, 9:55 AM

Change #1135911 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Use HookRunner for WikibaseClientEntityTypes hook

https://gerrit.wikimedia.org/r/1135911

gerritbot added a comment.Fri, Apr 11, 10:07 AM

Change #1135914 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/ArticlePlaceholder@master] Temporarily disable SpecialAboutTopicIntegrationTest::testExecution

https://gerrit.wikimedia.org/r/1135914

gerritbot added a comment.Fri, Apr 11, 10:37 AM

Change #1135924 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/ArticlePlaceholder@master] Re-enable SpecialAboutTopicIntegrationTest::testExecution test

https://gerrit.wikimedia.org/r/1135924

ArthurTaylor removed ArthurTaylor as the assignee of this task.Fri, Apr 11, 10:55 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor claimed this task.Mon, Apr 14, 8:22 AM
ArthurTaylor moved this task from Ready for Peer Review to In Development on the Wikidata-Omega (The Board) board.
ArthurTaylor removed ArthurTaylor as the assignee of this task.Mon, Apr 14, 9:06 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE claimed this task.Mon, Apr 14, 9:15 AM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Mon, Apr 14, 12:49 PM

Change #1135914 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Temporarily disable SpecialAboutTopicIntegrationTest::testExecution

https://gerrit.wikimedia.org/r/1135914

gerritbot added a comment.Mon, Apr 14, 12:49 PM

Change #1135904 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use HookRunner for WikibaseClientSiteLinksForItem

https://gerrit.wikimedia.org/r/1135904

gerritbot added a comment.Mon, Apr 14, 12:49 PM

Change #1135924 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Re-enable SpecialAboutTopicIntegrationTest::testExecution test

https://gerrit.wikimedia.org/r/1135924

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.25; 2025-04-15).Mon, Apr 14, 1:00 PM
gerritbot added a comment.Mon, Apr 14, 3:14 PM

Change #1135907 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use HookRunner for WikibaseClientDataTypes hook

https://gerrit.wikimedia.org/r/1135907

gerritbot added a comment.Mon, Apr 14, 4:13 PM

Change #1136410 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add configureHookRunner() to ServiceWiringTestCase

https://gerrit.wikimedia.org/r/1136410

gerritbot added a comment.Tue, Apr 15, 7:39 AM

Change #1136410 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add configureHookRunner() to ServiceWiringTestCase

https://gerrit.wikimedia.org/r/1136410

gerritbot added a comment.Tue, Apr 15, 1:52 PM

Change #1136729 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Migrate WikibaseContentLanguages hook

https://gerrit.wikimedia.org/r/1136729

gerritbot added a comment.Wed, Apr 16, 8:03 AM

Change #1136729 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate WikibaseContentLanguages hook

https://gerrit.wikimedia.org/r/1136729

gerritbot added a comment.Thu, Apr 17, 11:34 AM

Change #1135911 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use HookRunner for WikibaseClientEntityTypes hook

https://gerrit.wikimedia.org/r/1135911

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.26; 2025-04-22); removed MW-1.44-notes (1.44.0-wmf.25; 2025-04-15).Thu, Apr 17, 12:00 PM
gerritbot added a comment.Thu, Apr 17, 12:18 PM

Change #1137274 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Clean up hooks documentation

https://gerrit.wikimedia.org/r/1137274

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Thu, Apr 17, 12:19 PM
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Ready for Peer Review on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE subscribed.

Still to do once the above change is reviewed: migrate several hook handlers from static methods to proper handlers, such as EchoNotificationsHandlers. (Or is that a separate task? I couldn’t find one.)

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Thu, Apr 17, 4:28 PM
ArthurTaylor claimed this task.Tue, Apr 22, 6:48 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

Per T391444#10758341, I would say that we need a separate task for this. I will create it (/them).

gerritbot added a comment.Tue, Apr 22, 7:07 AM

Change #1137274 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Clean up hooks documentation

https://gerrit.wikimedia.org/r/1137274

ArthurTaylor mentioned this in T392412: Migrate static hook handlers in WikibaseClient to use HookRunner pattern.Tue, Apr 22, 7:30 AM
Maintenance_bot removed a project: Patch-For-Review.Tue, Apr 22, 7:30 AM
ArthurTaylor added a comment.EditedTue, Apr 22, 7:31 AM

Filed the follow-up as T392412

ArthurTaylor removed ArthurTaylor as the assignee of this task.Tue, Apr 22, 7:37 AM
ArthurTaylor moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.
ArthurTaylor updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits