Page MenuHomePhabricator

Daily flame graph for "fn-EditAction" missing since 28 March 2025
Closed, ResolvedPublic

Description

Event Timeline

Krinkle renamed this task from Daily flame graph for "fn-EditAction" missing as since 28 March 2025 to Daily flame graph for "fn-EditAction" missing since 28 March 2025.Apr 9 2025, 7:14 PM

The directory was never empty. This is about fn-EditAction which is still missing. Other datasets are unaffected.

This is still broken and makes various performance analysis and improvements hard or impossible.

For example, Ori's work to improve a Lua module on enwiki had quote that it would affect "0.5% of index.php" time. The person receiving that message didn't think it was a significant percentage. It is of course, because that is for all index.php traffic, including ParserCache hits and other unrelated requests. It is likely a substantial percentage of cpu-time for "edit" submissions specifically, but we can't easily quote that number because the telemetry for fn-EditAction has stopped working per this task.

Change #1231219 had a related patch set uploaded (by Ori; author: Ori):

[performance/arc-lamp@master] Fix matching of MediaWiki EditAction stack frames

https://gerrit.wikimedia.org/r/1231219

Change #1231219 merged by jenkins-bot:

[performance/arc-lamp@master] Fix matching of MediaWiki EditAction stack frames

https://gerrit.wikimedia.org/r/1231219

Mentioned in SAL (#wikimedia-operations) [2026-01-27T09:13:04Z] <cwhite@deploy2002> Started deploy [performance/arc-lamp@03c538c]: T391517

Mentioned in SAL (#wikimedia-operations) [2026-01-27T09:13:12Z] <cwhite@deploy2002> Finished deploy [performance/arc-lamp@03c538c]: T391517 (duration: 00m 08s)

Krinkle claimed this task.
From the task description:

And we've got fresh ones. Thank you! Closing as resolved.

The first (post-fix) complete day is Jan 25 (we keep 48h of logs on disk, I believe, so that makes sense):

https://performance.wikimedia.org/arclamp/svgs/daily/2026-01-25.excimer-wall.all.fn-EditAction.svgz
https://performance.wikimedia.org/arclamp/svgs/daily/2026-01-26.excimer-wall.all.fn-EditAction.svgz