Page MenuHomePhabricator

Abusefilter: Request confirmation for making a filter public
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):
Abusefilter should request a confirmation (interstitial) from the user when the user attempts to make a private filter into a public one. (a la the confirmation that displays for a purge action)

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
See T391509 where I apparently accidentally made a filter that was private public instead.

Benefits (why should this be implemented?):
Avoids accidental disclosure of private filter implementation.

Event Timeline

Change #1235546 had a related patch set uploaded (by Dragoniez; author: Dragoniez):

[mediawiki/extensions/AbuseFilter@master] Add confirmation for making a private filter public

https://gerrit.wikimedia.org/r/1235546

Dragoniez claimed this task.
Dragoniez removed a project: Patch-For-Review.
Dragoniez subscribed.

The patch got a +2 and will be merged soon.

Change #1235546 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Add confirmation for making a private filter public

https://gerrit.wikimedia.org/r/1235546