makerelease2.py doesn't like invalid JSON
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Apr 10 2025, 1:50 PM

Description

Not sure how this didn't break for 1.43.0, but...

Linting PHP and JSON files for validity...
Failed
./tests/phpunit/unit/tests/json/invalid-malformed.json is an invalid JSON file

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	tests: Rename invalid json files to txt	mediawiki/core	REL1_43	+3 -1
	tests: Rename invalid json files to txt	mediawiki/core	master	+3 -1

Mentioned Here: rMW5f2584b6486d: tests: Rename fixtures/bad.json
T306524: tests/phpunit/unit/includes/Settings/Source/fixtures/bad.json is an invalid JSON file
rMWd7ed4b14bb2f: REST: validate JSON in tests

Reedy triaged this task as High priority.Apr 10 2025, 1:50 PM

Reedy updated the task description. (Show Details)

Change #1135732 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] tests: Rename invalid json files to txt

Reedy raised the priority of this task from High to Unbreak Now!.Apr 10 2025, 2:07 PM

Change #1135732 merged by jenkins-bot:

[mediawiki/core@master] tests: Rename invalid json files to txt

Change #1135742 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_43] tests: Rename invalid json files to txt

Reedy closed this task as Resolved.Apr 10 2025, 2:39 PM

Reedy claimed this task.

Change #1135742 merged by jenkins-bot:

[mediawiki/core@REL1_43] tests: Rename invalid json files to txt