Replace ableist usage of `sane` and `insane` in libvmod-wmfuniq codebase
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• bd808
	Apr 10 2025, 9:05 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

BBlack

• bd808

Description

Per https://www.mediawiki.org/wiki/Inclusive_language sane and insane are generally considered ableist language. Often they can be replaced with more neutral terms such as "reasonable" or "wild".

$ git clone https://gitlab.wikimedia.org/repos/sre/libvmod-wmfuniq.git
$ cd libvmod-wmfuniq
$ git grep 'sane'
src/common.h:// multiplication is insane, etc.
src/cookies.c:               "our base64 buffer sizing is sane");
src/cookies.c:    // our only sane choice is to invalidate and replace these cookies, but we
src/cookies.h:// * Normally this call always returns zero.  If "dbl_now" time is insane
src/keys.c:        // be able to clean up the ring sanely based on count.

Details

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	Inclusive language fixes	repos/sre/libvmod-wmfuniq!10	bblack	work/bblack/inclusive_language	main

Customize query in GitLab

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		mpopov	T390849 [Epic] SDS 2.4.16 Establish Automated Analytics for Experiments Conducted With Experimentation Lab
Resolved		Milimetric	T392313 [Epic] SDS 2.4.11 Run a Synthetic A/A Experiment
Resolved		phuedx	T392317 [Epic] SDS 2.4.7 Client Libraries
Resolved		None	T392316 [Epic] SDS 2.4.10 Experiment Manager API
Resolved		phuedx	T391978 (stretch) Quality of life developer experience improvements
Resolved		phuedx	T393101 Experiment developer experience: automatic CSS tags
Resolved		cjming	T374840 xLab: Include experiment enrollment in the PHP client library
Resolved	Spike	phuedx	T390833 [SPIKE] Define/refine experiment-related instrumentation API
Resolved		cjming	T390597 PHP xLab SDK: Implement the PHP API for feature code to get the experiment and the assigned group
Resolved		Sfaci	T390089 JS xLab SDK: Implement the JS API we need for feature code to get the experiment and the assigned group
Resolved		Sfaci	T390060 xLab: Include experiment enrollment in the JS client library
Invalid		None	T391593 Client Libraries: stop automatically adding contextual attributes about the user's agent
Invalid		None	T391592 Client Libraries: plan and implement migration path for existing users
Resolved		Milimetric	T392315 [Epic] SDS 2.4.8 Eventgate updates
Resolved		Milimetric	T392314 [Epic] SDS 2.4.9 Synthetic Beacon Endpoints
Resolved		KOfori	T391411 SDS 2.4.4 Edge Uniques Production Cookie Deployment
Resolved	BUG REPORT	BBlack	T391633 Replace ableist usage of `sane` and `insane` in libvmod-wmfuniq codebase