Page MenuHomePhabricator
Create Task
Maniphest T39168

Translate extension should not reparse Gettext definition files for GettextDocumentationAid
Closed, ResolvedPublic
Actions

Description

Author: lockalsash

Description:
It seems that Translate extension reparses .pot files on each message edit. So more messages in definition file means longer loading time for edit form or page. Files with about 16000 messages leads to inevitable timeout on each message edit. Why messages can't be accessed only through the database?

Details

Reference
bz37168
SubjectRepoBranchLines +/-
Use MessageGroupCache in GettextDocumentationAidmediawiki/extensions/Translatemaster+37 -22
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:25 AM
• bzimport added a project: MediaWiki-extensions-Translate.
• bzimport set Reference to bz37168.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.May 28 2012, 6:20 PM
Nikerabbit added a comment.May 28 2012, 6:55 PM

It is loading comments which are not stored in the database.

siebrand added a comment.May 28 2012, 9:41 PM

I guess those should be added to the message cache, then?

Nikerabbit moved this task from Backlog to file formats on the MediaWiki-extensions-Translate board.Feb 1 2015, 5:35 PM
Nikerabbit renamed this task from Translate extension should not reparse definition files on each message edit to Translate extension should not reparse Gettext definition files for GettextDocumentationAid.Feb 26 2019, 3:11 PM
abi_ subscribed.Oct 31 2019, 12:23 PM
Nikerabbit mentioned this in T244494: Retain custom attributes added to the resource tag for AndroidXmlFFS.Feb 11 2020, 10:53 AM
Nikerabbit claimed this task.Apr 1 2020, 8:58 AM
Nikerabbit added a project: Language-Team (Language-2020-Focus-Sprint).
Nikerabbit updated the task description. (Show Details)
gerritbot added a comment.Apr 1 2020, 1:43 PM

Change 585229 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Use MessageGroupCache in GettextDocumentationAid

https://gerrit.wikimedia.org/r/585229

gerritbot added a project: Patch-For-Review.Apr 1 2020, 1:43 PM
Nikerabbit moved this task from Priority Backlog to In Progress on the Language-Team (Language-2020-Focus-Sprint) board.Apr 1 2020, 1:46 PM

This requires quite a bit of refactoring that affects many parts of the code, so this will take a while and requires careful testing. Incidentally, this also cleans up directly or makes it easy to clean up a lot of tech debt.

Nikerabbit moved this task from In Progress to In Review on the Language-Team (Language-2020-Focus-Sprint) board.Apr 2 2020, 12:38 PM
gerritbot added a comment.Apr 15 2020, 12:35 PM

Change 585229 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Use MessageGroupCache in GettextDocumentationAid

https://gerrit.wikimedia.org/r/585229

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 15 2020, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 15 2020, 1:11 PM
abi_ moved this task from In Review to Done on the Language-Team (Language-2020-Focus-Sprint) board.Apr 15 2020, 4:25 PM

Related changes have been merged, and deployed on twn. We will be monitoring them for a few days, and looking for any issues with Gettext based projects. If everything looks good, we will resolve this task.

abi_ closed this task as Resolved.May 6 2020, 3:11 PM

Haven't noticed any issues due to these changes on twn. Resolving the task.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL