Page MenuHomePhabricator

If I reject all link suggestions the final call to action should not be "Publish"
Closed, ResolvedPublic3 Estimated Story Points

Assigned To
Authored By
Esanders
Apr 11 2025, 3:47 PM
Referenced Files
F60325521: Screen Shot 2025-05-20 at 3.30.12 PM.png
May 20 2025, 10:35 PM
F60325516: Screen Shot 2025-05-20 at 3.30.25 PM.png
May 20 2025, 10:35 PM
F59542860: Screenshot 2025-04-29 at 11.56.29.png
Apr 29 2025, 10:06 AM
F59360110: image.png
Apr 23 2025, 3:08 PM
F59360107: image.png
Apr 23 2025, 3:08 PM
F59360098: image.png
Apr 23 2025, 3:08 PM
F59360093: image.png
Apr 23 2025, 3:08 PM

Description

And the dialog title should probably not be "Save your changes"

original_5819d376-5377-4679-8518-557360508ba5_PXL_20250411_154428156.jpg (2,945×4,080 px, 1 MB)
Screenshot 2025-04-29 at 11.56.29.png (1,014×652 px, 102 KB)
All suggestions rejectedSome suggestions rejected, rest unanswered

Acceptance criteria:

For the first iteration of this task, we want to change the label of the blue "Publish" button to read "Done" instead, iff the user has declined at least one of the suggestions and accepted none of the others.

current1st iteration
image.png (1,500×3,248 px, 167 KB)
image.png (1,500×3,248 px, 157 KB)

Event Timeline

KStoller-WMF moved this task from Inbox to Estimated tasks backlog on the Growth-Team board.

we've done some explorations, and this is where we landed! we could opt for a two-stage improvement: in the first iteration we could only change the UX copy of the dialog header and dialog main button, and remove the "Summary" label above the table given that we're moving that label inside the dialog header.

current1st iteration
image.png (1,500×3,248 px, 167 KB)
image.png (1,500×3,248 px, 157 KB)

in a second iteration we could also remove the legal text to avoid any confusing (this step might require legal review, we should open a separate task for that). the current verbiage says "By publishing..." which is not the case when a newcomer rejects all links suggestions. same is true for the "Review your changes" button, which opens an empty dialog.

currentreview your chages1st iteration2nd iteration
image.png (1,500×3,248 px, 167 KB)
image.png (1,500×3,248 px, 126 KB)
image.png (1,500×3,248 px, 157 KB)
image.png (1,500×3,248 px, 111 KB)
KStoller-WMF set the point value for this task to 3.Apr 28 2025, 4:30 PM
Sgs updated the task description. (Show Details)

Change #1144557 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Change button label to "Done" when all suggestions are rejected

https://gerrit.wikimedia.org/r/1144557

Change #1144557 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Change button label to "Done" when all suggestions are rejected

https://gerrit.wikimedia.org/r/1144557

Etonkovidova subscribed.

Checked on testwiki wmf.2 - 1st iteration UI change (Done label instead of Publish) is in place:

Screen Shot 2025-05-20 at 3.30.25 PM.png (1,040×708 px, 95 KB)
Screen Shot 2025-05-20 at 3.30.12 PM.png (1,932×488 px, 119 KB)