Page MenuHomePhabricator

Remove remaining lint errors in Rust
Closed, ResolvedPublic

Description

Description

cargo clippy
cargo fix
semgrep

  • clippy, cargo fix, and semgrep in function-evaluator
  • clippy, cargo fix, and semgrep in function-schemata

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • run it
  • ship it

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task


Completion checklist

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
update README w/ platform specificationrepos/abstract-wiki/wikifunctions/function-evaluator!400ecarggrace/T391716/update-readmemain
create new variant to add semgrep to CIrepos/abstract-wiki/wikifunctions/function-evaluator!386ecarggrace/T391716/run-semgrep-in-cimain
add static analysis tooling for rust coderepos/abstract-wiki/wikifunctions/function-evaluator!383ecarggrace/T391716/add-semgrepmain
Update function-schemata sub-module to HEAD (f6b01a6)repos/abstract-wiki/wikifunctions/wikilambda-cli!70jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (f6b01a6)repos/abstract-wiki/wikifunctions/function-evaluator!339jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (f6b01a6)repos/abstract-wiki/wikifunctions/function-orchestrator!357jforrestersync-function-schematamain
Draft: clippy for abstraction workrepos/abstract-wiki/wikifunctions/function-evaluator!335ecarggrace/T382045/run-clippymain
Add clippy as a dependency and apply fixes surfaced thereby.repos/abstract-wiki/wikifunctions/function-schemata!213apineapine-rust-clippymain
Add clippy as a dependency and fix lint issues surfaced thereby.repos/abstract-wiki/wikifunctions/function-evaluator!334apineapine-rust-clippymain
Customize query in GitLab

Event Timeline

cmassaro renamed this task from Remove remaining lint errors in Rust with cargo clippy to Remove remaining lint errors in Rust .Apr 11 2025, 7:06 PM
cmassaro updated the task description. (Show Details)
DSantamaria changed the task status from Open to In Progress.Apr 16 2025, 4:20 PM
DSantamaria edited projects, added Essential-Work; removed OKR-Work.

Change #1142527 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (eaa444c)

https://gerrit.wikimedia.org/r/1142527

Change #1142527 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (eaa444c)

https://gerrit.wikimedia.org/r/1142527

Change #1143074 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-04-16-213143 to 2025-05-07-003410

https://gerrit.wikimedia.org/r/1143074

Change #1143075 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-04-23-134615 to 2025-05-06-142345

https://gerrit.wikimedia.org/r/1143075

Change #1143074 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-04-16-213143 to 2025-05-07-003410

https://gerrit.wikimedia.org/r/1143074

Change #1143075 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-04-23-134615 to 2025-05-06-142345

https://gerrit.wikimedia.org/r/1143075

Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a subscriber: ecarg.

Who is working on this @Jdforrester-WMF or @cmassaro ?

Cory did the patch for function-schemata, now deployed; I believe @ecarg was doing this for the function-evaluator.

DSantamaria changed the task status from In Progress to Open.Jul 18 2025, 2:09 PM

As this is test-only code, it doesn't need to be deployed before it can be signed off.

Change #1186978 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-09-03-123051 to 2025-09-09-171717

https://gerrit.wikimedia.org/r/1186978

Change #1186978 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-09-03-123051 to 2025-09-09-171717

https://gerrit.wikimedia.org/r/1186978