Page MenuHomePhabricator
Create Task
Maniphest T391716

Remove remaining lint errors in Rust
Closed, ResolvedPublic
Actions

Description

Description

cargo clippy
cargo fix
semgrep

  • clippy, cargo fix, and semgrep in function-evaluator
  • clippy, cargo fix, and semgrep in function-schemata

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • run it
  • ship it

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade evaluators from 2025-09-03-123051 to 2025-09-09-171717operations/deployment-chartsmaster+2 -2
wikifunctions: Update orchestrator from 2025-04-23-134615 to 2025-05-06-142345operations/deployment-chartsmaster+1 -1
wikifunctions: Update evaluators from 2025-04-16-213143 to 2025-05-07-003410operations/deployment-chartsmaster+2 -2
Update function-schemata sub-module to HEAD (eaa444c)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
update README w/ platform specificationrepos/abstract-wiki/wikifunctions/function-evaluator!400ecarggrace/T391716/update-readmemain
create new variant to add semgrep to CIrepos/abstract-wiki/wikifunctions/function-evaluator!386ecarggrace/T391716/run-semgrep-in-cimain
add static analysis tooling for rust coderepos/abstract-wiki/wikifunctions/function-evaluator!383ecarggrace/T391716/add-semgrepmain
Update function-schemata sub-module to HEAD (f6b01a6)repos/abstract-wiki/wikifunctions/wikilambda-cli!70jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (f6b01a6)repos/abstract-wiki/wikifunctions/function-evaluator!339jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (f6b01a6)repos/abstract-wiki/wikifunctions/function-orchestrator!357jforrestersync-function-schematamain
Draft: clippy for abstraction workrepos/abstract-wiki/wikifunctions/function-evaluator!335ecarggrace/T382045/run-clippymain
Add clippy as a dependency and apply fixes surfaced thereby.repos/abstract-wiki/wikifunctions/function-schemata!213apineapine-rust-clippymain
Add clippy as a dependency and fix lint issues surfaced thereby.repos/abstract-wiki/wikifunctions/function-evaluator!334apineapine-rust-clippymain
Customize query in GitLab

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedcmassaroT391720 Address Rust security review findings
 ResolvedNoneT391721 Run cargo clippy/fix in CI
 ResolvedecargT391716 Remove remaining lint errors in Rust

Event Timeline

cmassaro created this task.Apr 11 2025, 6:32 PM
cmassaro renamed this task from Remove remaining lint errors in Rust with cargo clippy to Remove remaining lint errors in Rust .Apr 11 2025, 7:06 PM
cmassaro added a parent task: T391721: Run cargo clippy/fix in CI.
cmassaro updated the task description. (Show Details)
CodeReviewBot added a project: Patch-For-Review.Apr 11 2025, 8:32 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/334

Add clippy as a dependency and fix lint issues surfaced thereby.

CodeReviewBot added a comment.Apr 11 2025, 8:37 PM

apine closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/334

Add clippy as a dependency and fix lint issues surfaced thereby.

CodeReviewBot added a comment.Apr 11 2025, 8:41 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/213

Add clippy as a dependency and apply fixes surfaced thereby.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q4 (Apr–Jun)), OKR-Work; removed Abstract Wikipedia team.Apr 16 2025, 3:50 PM
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.Apr 16 2025, 3:57 PM
DSantamaria changed the task status from Open to In Progress.Apr 16 2025, 4:20 PM
DSantamaria triaged this task as Medium priority.Apr 16 2025, 4:34 PM
DSantamaria edited projects, added Essential-Work; removed OKR-Work.
CodeReviewBot added a comment.Apr 23 2025, 3:00 PM

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/213

Add clippy as a dependency and apply fixes surfaced thereby.

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2025, 3:31 PM
CodeReviewBot added a project: Patch-For-Review.Apr 29 2025, 4:00 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/357

Update function-schemata sub-module to HEAD (f6b01a6)

CodeReviewBot added a comment.Apr 29 2025, 4:01 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/339

Update function-schemata sub-module to HEAD (f6b01a6)

CodeReviewBot added a comment.Apr 29 2025, 4:02 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/70

Update function-schemata sub-module to HEAD (f6b01a6)

CodeReviewBot added a comment.Apr 29 2025, 9:45 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/357

Update function-schemata sub-module to HEAD (f6b01a6)

CodeReviewBot added a comment.Apr 29 2025, 9:46 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/339

Update function-schemata sub-module to HEAD (f6b01a6)

CodeReviewBot added a comment.Apr 29 2025, 9:46 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/70

Update function-schemata sub-module to HEAD (f6b01a6)

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2025, 10:30 PM
DSantamaria added subscribers: Jdforrester-WMF, DSantamaria.May 4 2025, 8:05 AM

Who is working on this @Jdforrester-WMF or @cmassaro ?

gerritbot added a comment.May 6 2025, 9:10 AM

Change #1142527 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (eaa444c)

https://gerrit.wikimedia.org/r/1142527

gerritbot added a project: Patch-For-Review.May 6 2025, 9:10 AM
gerritbot added a comment.May 6 2025, 2:26 PM

Change #1142527 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (eaa444c)

https://gerrit.wikimedia.org/r/1142527

Maintenance_bot removed a project: Patch-For-Review.May 6 2025, 2:31 PM
gerritbot added a comment.May 7 2025, 12:44 PM

Change #1143074 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-04-16-213143 to 2025-05-07-003410

https://gerrit.wikimedia.org/r/1143074

gerritbot added a project: Patch-For-Review.May 7 2025, 12:44 PM

Change #1143075 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-04-23-134615 to 2025-05-06-142345

https://gerrit.wikimedia.org/r/1143075

gerritbot added a comment.May 7 2025, 2:02 PM

Change #1143074 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-04-16-213143 to 2025-05-07-003410

https://gerrit.wikimedia.org/r/1143074

gerritbot added a comment.May 7 2025, 2:11 PM

Change #1143075 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-04-23-134615 to 2025-05-06-142345

https://gerrit.wikimedia.org/r/1143075

Maintenance_bot removed a project: Patch-For-Review.May 7 2025, 2:31 PM
Jdforrester-WMF assigned this task to ecarg.May 7 2025, 2:55 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a subscriber: ecarg.
In T391716#10789503, @DSantamaria wrote:

Who is working on this @Jdforrester-WMF or @cmassaro ?

Cory did the patch for function-schemata, now deployed; I believe @ecarg was doing this for the function-evaluator.

CodeReviewBot added a comment.May 12 2025, 1:06 PM

jforrester updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/335

Draft: clippy for abstraction work

DSantamaria edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (25Q4 (Apr–Jun)).May 14 2025, 1:48 PM
DSantamaria moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
cmassaro added a parent task: T382433: Get the Rust prototype of the function-evaluator's executors into a state where it could be deployed.May 21 2025, 12:26 PM
DSantamaria edited projects, added Abstract Wikipedia team (26Q1 (Jul–Sep)); removed Abstract Wikipedia team.Jul 16 2025, 2:12 PM
DSantamaria moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.
DSantamaria changed the task status from In Progress to Open.Jul 18 2025, 2:09 PM
Jdforrester-WMF changed the task status from Open to In Progress.Jul 30 2025, 3:51 PM
Jdforrester-WMF moved this task from Ready to In Engineering on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.
CodeReviewBot added a project: Patch-For-Review.Aug 25 2025, 11:01 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/383

add static analysis tooling for rust code

CodeReviewBot added a comment.Aug 25 2025, 11:31 PM

ecarg closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/335

Draft: clippy for abstraction work

CodeReviewBot added a comment.Aug 28 2025, 8:10 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/386

run semgrep in CI

CodeReviewBot added a comment.Sep 8 2025, 3:51 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/383

add static analysis tooling for rust code

Jdforrester-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.Sep 8 2025, 4:33 PM
CodeReviewBot added a comment.Sep 8 2025, 5:48 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/386

create new variant to add semgrep to CI

Jdforrester-WMF moved this task from In Code review to Needs Sign-off on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.Sep 8 2025, 5:51 PM

As this is test-only code, it doesn't need to be deployed before it can be signed off.

CodeReviewBot added a comment.Sep 8 2025, 6:51 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/400

update README w/ platform specification

CodeReviewBot added a comment.Sep 8 2025, 7:04 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/400

update README w/ platform specification

gerritbot added a comment.Sep 10 2025, 12:50 PM

Change #1186978 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-09-03-123051 to 2025-09-09-171717

https://gerrit.wikimedia.org/r/1186978

gerritbot added a comment.Sep 10 2025, 2:02 PM

Change #1186978 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-09-03-123051 to 2025-09-09-171717

https://gerrit.wikimedia.org/r/1186978

Jdforrester-WMF closed this task as Resolved.Sep 16 2025, 1:54 PM
Jdforrester-WMF removed a parent task: T382433: Get the Rust prototype of the function-evaluator's executors into a state where it could be deployed.Oct 1 2025, 8:54 PM
DMartin-WMF mentioned this in rMSFE3cbd48babffa: Update function-schemata sub-module to HEAD (f6b01a6).Oct 3 2025, 9:44 AM
Jdforrester-WMF mentioned this in rMSFEf60474cd9c75: add static analysis tooling for rust code.Oct 3 2025, 9:45 AM
Jdforrester-WMF mentioned this in rMSFE3e24415b3384: build: Create new pipeline variant to add semgrep to CI.
cmassaro mentioned this in rMSFEf9e3c62e34c7: update README w/ platform specification.Oct 3 2025, 9:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits