Maniphest T391721

Run cargo clippy/fix in CI
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	cmassaro
	Apr 11 2025, 7:06 PM

Tags

Referenced Files

None

Subscribers

Description

Description

Enough said!

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

run cargo flippy, cargo fix, and semgrep in the lint step for function-evaluator
run cargo flippy, cargo fix, and semgrep in CI for function-schemata

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		cmassaro	T391720 Address Rust security review findings
		Resolved		None	T391721 Run cargo clippy/fix in CI
		Resolved		ecarg	T391716 Remove remaining lint errors in Rust

Event Timeline

cmassaro created this task.Apr 11 2025, 7:06 PM

cmassaro added a subtask: T391716: Remove remaining lint errors in Rust .

cmassaro added a parent task: T391720: Address Rust security review findings.

cmassaro updated the task description. (Show Details)

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q4 (Apr–Jun)), OKR-Work; removed Abstract Wikipedia team.Apr 16 2025, 3:50 PM

Jdforrester-WMF moved this task from Incoming to Ready on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.Apr 16 2025, 3:57 PM

DSantamaria changed the status of subtask T391716: Remove remaining lint errors in Rust from Open to In Progress.Apr 16 2025, 4:20 PM

DSantamaria triaged this task as Medium priority.Apr 16 2025, 4:29 PM

DSantamaria edited projects, added Essential-Work; removed OKR-Work.

DSantamaria edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (25Q4 (Apr–Jun)).May 14 2025, 1:47 PM

DSantamaria moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.

cmassaro added a parent task: T382433: Get the Rust prototype of the function-evaluator's executors into a state where it could be deployed.May 21 2025, 12:26 PM

DSantamaria edited projects, added Abstract Wikipedia team (26Q1 (Jul–Sep)); removed Abstract Wikipedia team.Jul 16 2025, 2:11 PM

DSantamaria moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

DSantamaria changed the status of subtask T391716: Remove remaining lint errors in Rust from In Progress to Open.Jul 18 2025, 2:09 PM

Jdforrester-WMF changed the status of subtask T391716: Remove remaining lint errors in Rust from Open to In Progress.Jul 30 2025, 3:51 PM

IIRC this was completed; moving to 'sign-off' but feel free to move back if I'm mistaken

You're right! I will close it.

cmassaro closed this task as Resolved.Aug 22 2025, 9:07 PM

cmassaro updated the task description. (Show Details)

Jdforrester-WMF closed subtask T391716: Remove remaining lint errors in Rust as Resolved.Sep 16 2025, 1:54 PM

Jdforrester-WMF removed a parent task: T382433: Get the Rust prototype of the function-evaluator's executors into a state where it could be deployed.Oct 1 2025, 8:54 PM