Page MenuHomePhabricator

[QA task] testwiki - wikifunctions integration testing
Closed, ResolvedPublic

Description

Issues

(see the section below)


* Issues that have been addressed/out of scope etc

DONE - should be tested on testwiki with ?useparsoid=1 (1) Unable to publish (save) inserted function. View history and Special:Contributions show unsaved edits as completed.**

{{#function:Z18435|2,025|Z16108|1}}` as added

  • switch to Edit mode: "The function is unable to display a result. Learn more"

Screen Shot 2025-04-11 at 5.15.15 PM.png (1×2 px, 301 KB)

  • click in the error message - a suggestion to edit appears

Screen Shot 2025-04-11 at 5.01.18 PM.png (950×2 px, 181 KB)

  • click on Edit, the Console error is displayed:
Uncaught (in promise) Error: You have too many function calls executing right now.

As Designed (2) No back button on the insert wikifunction overlay?

Figma designtestwiki wmf.25
Screen Shot 2025-04-11 at 5.38.57 PM.png (1×1 px, 138 KB)
Screen Shot 2025-04-11 at 5.38.57 PM.png (1×1 px, 138 KB)
  • a user cannot return to the Search for wikifunctions overlay
  • dismissing (clicking on x) will close the overlay and a user needs to click on the Insert menu and click on the Function menu item to start insertin a new wikifunction.
  • no shortcuts for inserting wikifunctions (cmd+? for VE shortcuts)

Out of scope - pending feedback (3) The error message doesn't mention the wikifunction name

Screen Shot 2025-04-11 at 5.01.18 PM.png (950×2 px, 181 KB)

✅ - Filed as T392638 (4) No VE preview - after editing/updating wikifunctions on a page, a preview is shown only in wikitext.

  • on testwiki, in User preferences - Editing enable the following settings (those settings are not default on testwiki)
    • "Use the wikitext mode inside the visual editor, instead of a different wikitext editor" This is sometimes called the '2017 wikitext editor'.
    • "Use the new Parsoid wikitext parser: Always (opt-in)
    • in VE on any page insert any function, e.g. "Natural number as Roman numeral" (Z11022)

{{#function:Z11022|123}}

  • after the inserted wikifunctions is successfully displayed in VE, click on "Publish Changes"
  • return to VE to correct the function you just inserted. to

{{#function:Z11022|126}}

  • click on "Publish Changes" - and in the "Save your changes" dialog, click on "Review your changes" - the wikitext review displays the changes correctly:

Screen Shot 2025-04-23 at 2.07.42 PM.png (1×2 px, 214 KB)

  • switch to Visual preview - the Visual review is not loading and the Console displays the following error:
TypeError: Cannot read properties of null (reading 'length')
   at ve.batchPush (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.core.utils&skin=vector-2022&version=1d3dw:3:400)
   at eval (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.diffing&skin=vector-2022&version=1ib7h:55:65)
   at Array.forEach (<anonymous>)
   at ve.ui.DiffElement.annotateNode (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.diffing&skin=vector-2022&version=1ib7h:54:922)
   at ve.ui.DiffElement.getChangedLeafNodeData (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.diffing&skin=vector-2022&version=1ib7h:38:78)
   at ve.ui.DiffElement.getChangedNodeData (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.diffing&skin=vector-2022&version=1ib7h:37:488)
   at ve.ui.DiffElement.getChangedNodeElements (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.diffing&skin=vector-2022&version=1ib7h:37:223)

Screen Shot 2025-04-23 at 2.09.10 PM.png (1×2 px, 191 KB)

✅ - will be addressed as part of T392638 (5) (a variation of (4)) &veaction=editsource shows non-rendered wikifunction

  • with enabled " "Use the wikitext mode inside the visual editor ..." insert the following:
[[File:Lilac Flower&Leaves, SC, Vic, 13.10.2007.jpg|thumb|test image]]
{{Date}} - Date template example 
{{#function:Z11022|128}}
  • click "Publish changes"
  • in the "Save your changes" dialog click on "Show preview" - the inserted image and the template will be displayed rendered, but the wikifunction would be displayed as wikitext:

Screen Shot 2025-04-23 at 2.17.42 PM.png (1×2 px, 503 KB)

✅ - filed T392722 (6) wikifunction insert dialog link opens in the same tab

  • In the insert function dialog, the following link opens in the same tab, warning users that they are about to leave a page:

<span class="ext-wikilambda-app-function-input-setup__link"><a title="F:Z10000" href="/wiki/F:Z10000">Function</a> from Wikifunctions</span>

Screen Shot 2025-04-22 at 5.18.39 PM.png (1×1 px, 320 KB)