Page MenuHomePhabricator

Increase file processing timeout
Closed, ResolvedPublic

Description

Now that we've statically defined the dumps DAG, we've seen DAG processing times jump from ~1s to ~7s with 32 wikis. We need to adjust the file processing timeout.

I suggest setting it to a super high value, measure how much time it really takes the scheduler to parse the DAG with all the wikis, and adjust the value more realistically.

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
test_k8s/dumpsv1: define the list of wikis in JSON filesrepos/data-engineering/airflow-dags!1234brouberolT391744main
Customize query in GitLab

Event Timeline

brouberol triaged this task as Medium priority.

An initial test of importing the DAG with all 1008 wikis shows an import time of 3 min 33s.

Screenshot 2025-04-14 at 12.53.11.png (2,962×1,970 px, 491 KB)

I think we can safely set

dag_file_processor_timeout: 300
dagbag_import_timeout: 300

Change #1136351 had a related patch set uploaded (by Brouberol; author: Brouberol):

[operations/deployment-charts@master] airflow-test-k8s: adjust dag/file processing timeout to account for large v1 dumps dags

https://gerrit.wikimedia.org/r/1136351

Screenshot 2025-04-14 at 13.48.27.png (2,618×786 px, 283 KB)

I've also experimented with using chain(tg_tasks) instead of using my manual wiring, and it seems to be slower, by ~30s. I'm going to stick to the faster implementation.

Change #1136351 merged by Brouberol:

[operations/deployment-charts@master] airflow-test-k8s: adjust dag/file processing timeout to account for large v1 dumps dags

https://gerrit.wikimedia.org/r/1136351

brouberol claimed this task.