Page MenuHomePhabricator
Create Task
Maniphest T391871

PHP Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.24/includes/config/SiteConfiguration.php(513)
#0[internal function]MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.44.0-wmf.24/includes/config/SiteConfiguration.php(513)str_ends_with(null, string)
#2/srv/mediawiki/php-1.44.0-wmf.24/extensions/SecurePoll/includes/User/RemoteMWAuth.php(65)MediaWiki\Config\SiteConfiguration->siteFromDB(null)
#3/srv/mediawiki/php-1.44.0-wmf.24/extensions/SecurePoll/includes/User/Auth.php(181)MediaWiki\Extension\SecurePoll\User\RemoteMWAuth->requestLogin(MediaWiki\Extension\SecurePoll\Entities\Election)
#4/srv/mediawiki/php-1.44.0-wmf.24/extensions/SecurePoll/includes/Pages/LoginPage.php(31)MediaWiki\Extension\SecurePoll\User\Auth->newRequestedSession(MediaWiki\Extension\SecurePoll\Entities\Election)
#5/srv/mediawiki/php-1.44.0-wmf.24/extensions/SecurePoll/includes/SpecialSecurePoll.php(66)MediaWiki\Extension\SecurePoll\Pages\LoginPage->execute(array)
#6/srv/mediawiki/php-1.44.0-wmf.24/includes/specialpage/SpecialPage.php(729)MediaWiki\Extension\SecurePoll\SpecialSecurePoll->execute(string)
#7/srv/mediawiki/php-1.44.0-wmf.24/includes/specialpage/SpecialPageFactory.php(1738)MediaWiki\SpecialPage\SpecialPage->run(string)
#8/srv/mediawiki/php-1.44.0-wmf.24/includes/actions/ActionEntryPoint.php(499)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#9/srv/mediawiki/php-1.44.0-wmf.24/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#10/srv/mediawiki/php-1.44.0-wmf.24/includes/MediaWikiEntryPoint.php(202)MediaWiki\Actions\ActionEntryPoint->execute()
#11/srv/mediawiki/php-1.44.0-wmf.24/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#12/srv/mediawiki/w/index.php(3)require(string)
#13{main}
Impact
Notes

Details

Request URL
https://vote.wikimedia.org/wiki/Special:SecurePoll/login/1208
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Deprecate calling public methods of SiteConfiguration with incorrect typed argsmediawiki/coremaster+125 -0
SiteConfiguration::siteFromDb: Don't risk passing null into str_ends_withmediawiki/coremaster+1 -1
Handle missing 'wiki' parametermediawiki/extensions/SecurePollmaster+12 -10
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
ResolvedPRODUCTION ERRORJdforrester-WMFT391871 PHP Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated
· · ·

Event Timeline

Reedy created this task.Apr 14 2025, 5:19 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptApr 14 2025, 5:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.Apr 14 2025, 5:19 PM
Reedy added a project: PHP 8.1 support.Apr 14 2025, 5:23 PM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.Apr 14 2025, 5:25 PM
Reedy moved this task from Untriaged to Apr-Jun 2025 on the Wikimedia-production-error board.Apr 14 2025, 5:40 PM
gerritbot added a comment.Apr 24 2025, 11:28 AM

Change #1138717 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] SiteConfiguration::siteFromDb: Don't risk passing null into str_ends_with

https://gerrit.wikimedia.org/r/1138717

gerritbot added a project: Patch-For-Review.Apr 24 2025, 11:28 AM
Jdforrester-WMF changed the task status from Open to In Progress.Apr 24 2025, 11:28 AM
Jdforrester-WMF claimed this task.
gerritbot added a comment.Apr 24 2025, 3:09 PM

Change #1138826 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/SecurePoll@master] Handle missing 'wiki' parameter

https://gerrit.wikimedia.org/r/1138826

gerritbot added a comment.Apr 24 2025, 5:45 PM

Change #1138862 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Deprecate calling public methods of SiteConfig with incorrect typed args

https://gerrit.wikimedia.org/r/1138862

Tchanders added a project: Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)).Apr 25 2025, 8:45 PM
Tchanders moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)) board.
Tchanders added subscribers: STran, • mszabo.
gerritbot added a comment.Apr 28 2025, 2:02 PM

Change #1138826 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Handle missing 'wiki' parameter

https://gerrit.wikimedia.org/r/1138826

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).Apr 28 2025, 3:00 PM
gerritbot added a comment.May 2 2025, 7:56 AM

Change #1138717 abandoned by Jforrester:

[mediawiki/core@master] SiteConfiguration::siteFromDb: Don't risk passing null into str_ends_with

Reason:

Let's go with I8df48a00e1b5c043bed95efdeab42ed99a5b98da.

https://gerrit.wikimedia.org/r/1138717

gerritbot added a comment.May 2 2025, 8:30 AM

Change #1138862 merged by jenkins-bot:

[mediawiki/core@master] Deprecate calling public methods of SiteConfiguration with incorrect typed args

https://gerrit.wikimedia.org/r/1138862

Maintenance_bot removed a project: Patch-For-Review.May 2 2025, 8:30 AM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.28; 2025-05-06); removed MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).May 2 2025, 9:00 AM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)); removed Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)).May 5 2025, 6:49 AM
kostajh moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.
kostajh subscribed.May 5 2025, 7:30 AM

Is this done?

• mszabo closed this task as Resolved.May 6 2025, 8:49 PM
• mszabo moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits