Page MenuHomePhabricator
Create Task
Maniphest T391913

[PHP]: Add rights for creation & editing of lightweight enum types
Closed, ResolvedPublic
Actions

Description

Description

Determine and implement rights for working with these aspects of lightweight enum types:

  • creation rights:
    • wikilambda-create-generic-enum to group functioneer
    • fallback wikilambda-create-function-call disallowed
  • editing rights:
    • Z6884K1/Wikidata reference type: wikilambda-edit-generic-enum-type to group function maintainer
    • Z6884K2/list of Wikidata references: wikilambda-edit-generic-enum-item to group functioneer
    • Z688K3/id: wikilambda-edit-generic-enum-id to group sysop
    • fallback any edit in a persisted Z7: wikilambda-edit-function-call disallowed

Some other examples of granular auth rules patches

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[wikifunctions] Don't grant new generic-enum rights to Functioneers for nowoperations/mediawiki-configmaster+19 -1
Add create and granular edit rights for lightweight enumsmediawiki/extensions/WikiLambdamaster+594 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

DMartin-WMF created this task.Apr 15 2025, 4:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2025, 4:23 AM
DMartin-WMF added a parent task: T391226: Demonstrate the creation of a lightweight enum type and its use with a function.Apr 15 2025, 4:56 AM
DMartin-WMF added a subtask: T391221: Create generic-type functions for Wikidata entity-based lightweight enums.Apr 15 2025, 5:01 AM
DMartin-WMF added a project: OKR-Work.Apr 15 2025, 5:10 AM
DMartin-WMF moved this task from Incoming to Ready on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
DMartin-WMF updated the task description. (Show Details)Apr 15 2025, 5:27 AM
DSantamaria triaged this task as Medium priority.Apr 15 2025, 12:53 PM
gengh mentioned this in T391918: [Front-end/Default view]: Allow easy creation and edition of valid and wellformed lightweight enum types.Apr 23 2025, 7:07 PM
DMartin-WMF closed subtask T391221: Create generic-type functions for Wikidata entity-based lightweight enums as Resolved.May 19 2025, 9:43 PM
gengh changed the task status from Open to In Progress.May 20 2025, 11:14 AM
gengh claimed this task.
gengh moved this task from Ready to In Engineering on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
gengh updated the task description. (Show Details)May 20 2025, 11:28 AM
gengh updated the task description. (Show Details)
gerritbot added a comment.May 20 2025, 7:01 PM

Change #1148427 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Add create and granular edit rights for lightweight enums

https://gerrit.wikimedia.org/r/1148427

gerritbot added a project: Patch-For-Review.May 20 2025, 7:01 PM
gerritbot added a comment.May 21 2025, 10:49 AM

Change #1148828 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add create and granular edit rights for lightweight enums

https://gerrit.wikimedia.org/r/1148828

gengh updated the task description. (Show Details)May 21 2025, 11:02 AM
gengh added a comment.May 21 2025, 11:07 AM

@DMartin-WMF I've created the granular rights and assigned it to different groups as per this task description:

  • functioneers will be able to create new WD enum types
  • and for edit:
    • any functioneer will be able to add new items (or remove or edit items) from an existing WD enum type
    • only function maintaners will be able to change the type of an existing WD enum type
    • only sysops will be able to change the ID of an existing WD enum type

Does this work?

gengh moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.May 21 2025, 11:24 AM
DMartin-WMF added a comment.May 21 2025, 3:44 PM

Thanks @gengh ! Yes, this looks right to me.

gerritbot added a comment.May 21 2025, 7:51 PM

Change #1148828 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add create and granular edit rights for lightweight enums

https://gerrit.wikimedia.org/r/1148828

gerritbot added a comment.May 21 2025, 8:02 PM

Change #1148951 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/mediawiki-config@master] [wikifunctions] Don't grant new generic-enum rights to Functioneers for now

https://gerrit.wikimedia.org/r/1148951

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.May 21 2025, 8:02 PM
gerritbot added a comment.May 27 2025, 3:31 PM

Change #1148951 merged by jenkins-bot:

[operations/mediawiki-config@master] [wikifunctions] Don't grant new generic-enum rights to Functioneers for now

https://gerrit.wikimedia.org/r/1148951

Stashbot mentioned this in T390552: Make embedded Wikifunctions available in at least five more Wikimedia projects, to learn from other languages and communities.May 27 2025, 3:31 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-27T15:31:46Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1148951|[wikifunctions] Don't grant new generic-enum rights to Functioneers for now (T391913)]], [[gerrit:1148423|Wikifunctions: Enable Wikifunction client mode on the first five Wiktionaries (T390552)]]

Stashbot added a comment.May 27 2025, 3:33 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-27T15:33:55Z] <jforrester@deploy1003> jforrester: Backport for [[gerrit:1148951|[wikifunctions] Don't grant new generic-enum rights to Functioneers for now (T391913)]], [[gerrit:1148423|Wikifunctions: Enable Wikifunction client mode on the first five Wiktionaries (T390552)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.May 27 2025, 3:42 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-27T15:42:36Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1148951|[wikifunctions] Don't grant new generic-enum rights to Functioneers for now (T391913)]], [[gerrit:1148423|Wikifunctions: Enable Wikifunction client mode on the first five Wiktionaries (T390552)]] (duration: 10m 50s)

Jdforrester-WMF closed this task as Resolved.Jun 10 2025, 2:00 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits