Page MenuHomePhabricator
Create Task
Maniphest T391915

[PHP/DB]: Audit and fix the way lightweight enum types are registered in the secondary tables to make them searchable
Closed, ResolvedPublic
Actions

Description

Description

  • For wikilambdasearch_labels: the return type should be Z4
  • Consider whether there are other implications for filter functions and special pages

Open questions

  • Should type be Z4. As in 'wikilambdasearch_type=Z4' ? Because it already returns when 'wikilambdasearch_return_type=Z4'. The Frontend uses the wikilambdasearch_type=Z4' in the ZObjectSelector

current vars on fe:
wikilambdasearch_search: enum
wikilambdasearch_type: Z4
wikilambdasearch_return_type: Z4
wikilambdasearch_strict_return_type: true

  • Add more detailed description + Acceptance criteria to this ticket
  • We should describe the other implications. Unsure what Special Pages might be implicated here

Desired behavior/Acceptance criteria

  • ...

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix label search so that it can aggregate return types from wikilambda_zobject_joinmediawiki/extensions/WikiLambdamaster+719 -447
Add additional handling of lightweight enum types in secondary tablesmediawiki/extensions/WikiLambdamaster+123 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

DMartin-WMF created this task.Apr 15 2025, 4:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2025, 4:30 AM
DMartin-WMF added a parent task: T391916: [Front-end/Function editor]: Adapt Type Selector to work with lightweight enum types.Apr 15 2025, 4:51 AM
DMartin-WMF added a subtask: T391221: Create generic-type functions for Wikidata entity-based lightweight enums.Apr 15 2025, 5:02 AM
DMartin-WMF added a project: OKR-Work.Apr 15 2025, 5:11 AM
DMartin-WMF moved this task from Incoming to Ready on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
DSantamaria triaged this task as Medium priority.Apr 15 2025, 12:53 PM
DSmit-WMF updated the task description. (Show Details)Apr 23 2025, 2:48 PM
DSmit-WMF updated the task description. (Show Details)
gengh mentioned this in T391916: [Front-end/Function editor]: Adapt Type Selector to work with lightweight enum types.Apr 24 2025, 9:09 AM
DSmit-WMF subscribed.Apr 24 2025, 9:28 AM
gengh mentioned this in T391917: [Front-end/Default view]: Adapt enum selector to also accommodate lightweight enum types .Apr 24 2025, 9:58 AM
DSmit-WMF updated the task description. (Show Details)Apr 24 2025, 10:18 AM
DSmit-WMF changed the task status from Open to In Progress.May 12 2025, 1:00 PM
DSmit-WMF claimed this task.
DSmit-WMF moved this task from Ready to In Engineering on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
gerritbot added a comment.May 12 2025, 3:20 PM

Change #1144597 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Add additional handling of lightweight enum types in secondary tables

https://gerrit.wikimedia.org/r/1144597

gerritbot added a project: Patch-For-Review.May 12 2025, 3:20 PM
DSmit-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.May 12 2025, 3:22 PM
DMartin-WMF closed subtask T391221: Create generic-type functions for Wikidata entity-based lightweight enums as Resolved.May 19 2025, 9:43 PM
gerritbot added a comment.May 22 2025, 5:58 PM

Change #1149452 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Fix label search so that it can aggregate return types from wikilambda_zobject_join

https://gerrit.wikimedia.org/r/1149452

gerritbot added a comment.May 26 2025, 3:41 PM

Change #1144597 abandoned by Genoveva Galarza:

[mediawiki/extensions/WikiLambda@master] Add additional handling of lightweight enum types in secondary tables

Reason:

This change is not needed anymore

https://gerrit.wikimedia.org/r/1144597

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.May 27 2025, 5:13 PM
gerritbot added a comment.May 27 2025, 5:21 PM

Change #1149452 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix label search so that it can aggregate return types from wikilambda_zobject_join

https://gerrit.wikimedia.org/r/1149452

Maintenance_bot removed a project: Patch-For-Review.May 27 2025, 5:30 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.Jun 10 2025, 2:00 PM
Jdforrester-WMF added a project: MW-1.45-notes (1.45.0-wmf.4; 2025-06-03).
Jdforrester-WMF closed this task as Resolved.Jun 16 2025, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits