Page MenuHomePhabricator
Create Task
Maniphest T39194

remove *.deps.php files
Closed, ResolvedPublic
Actions

Description

PHP had a nasty bug related to late/early binding and referenced at https://bugs.php.net/bug.php?id=56776 . The workaround was to add some .deps.php files to make sure code is loaded early.

$ find . -name '*deps.php'
./languages/classes/LanguageIu.deps.php
./languages/classes/LanguageKk.deps.php
./languages/classes/LanguageKu.deps.php
./languages/classes/LanguageShi.deps.php
./languages/classes/LanguageSr.deps.php
./languages/classes/LanguageZh.deps.php
./skins/Chick.deps.php
./skins/Modern.deps.php
./skins/MonoBook.deps.php
./skins/MySkin.deps.php
./skins/Simple.deps.php
./skins/Vector.deps.php

Since bug upstream php issue #56778 was fixed in PHP 5.1, I guess we can get ride of the deps files.

Version: 1.20.x
Severity: minor

Details

Reference
bz37194

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 12:27 AM
• bzimport added projects: MediaWiki-General, platformeng.
• bzimport set Reference to bz37194.
• bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.May 29 2012, 12:00 PM
hashar added a comment.May 29 2012, 12:06 PM

Proposed change: https://gerrit.wikimedia.org/r/9242

hashar added a comment.May 31 2012, 6:23 PM

merged by Sam Reed. Will be in some 1.20wmf > 4 / MediaWiki 1.20

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits