Page MenuHomePhabricator
Create Task
Maniphest T392049

SpecialBlock [codex] - Can't add IP block if IP is within an already blocked range
Closed, ResolvedPublicBUG REPORT
Actions

Description

When multiblocks is disabled if an admin tries to block an IP that is already blocked by a range block, form is never shown

Steps to reproduce:

  • Create a block on 127.0.0.1/16
  • Try to create a block on 127.0.0.20
  • Form is still hidden

Derived Requirement

Ensure that when MultiBlocks is disabled, admins are able to view and interact with the Special:Block form when attempting to block a single IP address that falls within an already blocked IP range.

Test Steps

Test Case 1: Ensure form is visible when blocking an IP within an existing blocked range with MultiBlocks disabled

  1. Disable MultiBlocks ($wgEnableMultiBlocks = false) on the wiki.
  2. Log in as an admin user with permission to block users.
  3. Navigate to Special:Block.
  4. Block the IP range '127.0.0.1/16'.
  5. After the block is created, attempt to block the individual IP '127.0.0.20'.
  6. ✅❓❌⬜ AC1: Confirm that the Special:Block form displays correctly and allows setting a new block on '127.0.0.20'.

Test Case 2: Verify correct behavior when blocking an IP within an existing blocked range with MultiBlocks enabled

  1. Enable MultiBlocks ($wgEnableMultiBlocks = true) on the wiki.
  2. Log in as an admin user with permission to block users.
  3. Navigate to Special:Block.
  4. Block the IP range '127.0.0.1/16'.
  5. After creating the blo, attempt to block the individual IP '127.0.0.20'.
  6. ✅❓❌⬜ AC2: Confirm that the Special:Block form displays correctly, allowing the admin to create an overlapping block on '127.0.0.20' without errors.

QA Results - Local

ACStatusDetails
1✅T392049#10777595
2✅T392049#10777595

Details

SubjectRepoBranchLines +/-
SpecialBlock [codex]: Fix add ip block when block range presentmediawiki/coremaster+42 -1
Customize query in gerrit

Related Objects

Event Timeline

dmaza created this task.Wed, Apr 16, 2:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Apr 16, 2:56 AM
dom_walden subscribed.Wed, Apr 16, 7:16 AM

@dmaza This is a good catch. Is this with $wgEnableMultiBlocks = false? When it is true, I find I can still press "Add block" to create a block. I think this is a side-effect of T389987.

dom_walden mentioned this in T389987: Special:Block [Codex]: Surface any range blocks that effect the target.Wed, Apr 16, 7:17 AM
Reedy renamed this task from SpecialBLock [codex] - Can't add IP block if IP is within an already blocked range to SpecialBlock [codex] - Can't add IP block if IP is within an already blocked range.Wed, Apr 16, 12:18 PM
dmaza added a comment.Wed, Apr 16, 2:26 PM
In T392049#10746425, @dom_walden wrote:

@dmaza This is a good catch. Is this with $wgEnableMultiBlocks = false? When it is true, I find I can still press "Add block" to create a block. I think this is a side-effect of T389987.

Yes, this is only with $wgEnableMultiBlocks = false. I think it is related to the IP being considered "blocked" by the range. I don't think T389987 is causing this but I'll investigate

dmaza changed the subtype of this task from "Task" to "Bug Report".EditedWed, Apr 16, 2:34 PM

@dom_walden I checked on a random commit ( df3aae487aa ) before T389987 and it is still happening.

dmaza added a comment.EditedWed, Apr 16, 2:45 PM
In T392049#10748088, @dmaza wrote:

@dom_walden I checked on a random commit ( df3aae487aa ) before T389987 and it is still happening.

My bad, pulled the wrong commit. This is indeed happening after T389987

JWheeler-WMF moved this task from New & TBD Tickets to Sea Lion Squad on the Community-Tech board.Wed, Apr 16, 4:04 PM
JWheeler-WMF edited projects, added Community-Tech (Sea Lion Squad); removed Community-Tech.
dmaza claimed this task.Wed, Apr 16, 4:06 PM
dmaza moved this task from Backlog - groomed to In Development on the Community-Tech (Sea Lion Squad) board.
gerritbot added a comment.Thu, Apr 17, 3:50 PM

Change #1137317 had a related patch set uploaded (by Dmaza; author: Dmaza):

[mediawiki/core@master] SpecialBlock [codex]: Fix add ip block when block range present

https://gerrit.wikimedia.org/r/1137317

gerritbot added a project: Patch-For-Review.Thu, Apr 17, 3:50 PM
dmaza moved this task from In Development to Feedback and Review on the Community-Tech (Sea Lion Squad) board.Thu, Apr 17, 3:53 PM
gerritbot added a comment.Tue, Apr 22, 6:43 AM

Change #1137317 merged by jenkins-bot:

[mediawiki/core@master] SpecialBlock [codex]: Fix add ip block when block range present

https://gerrit.wikimedia.org/r/1137317

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).Tue, Apr 22, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Tue, Apr 22, 7:30 AM
dmaza moved this task from Feedback and Review to QA on the Community-Tech (Sea Lion Squad) board.Tue, Apr 22, 7:49 PM
GMikesell-WMF updated the task description. (Show Details)Mon, Apr 28, 8:18 PM
GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.
GMikesell-WMF subscribed.Tue, Apr 29, 5:06 PM

@dmaza Confirmed that the Special:Block form displays correctly and allows the form to open even within the IP range that is blocked vs Different IP ranges vs IP ranges block within each other, as seen in the gifs. I will mark this as Resolved. Thanks for all your work!

Test Result - Local

Status: ✅ PASS
Environment: Local- MediaWiki: 1.44.0-alpha (4e09390) 17:02, 23 April 2025
OS: macOS Sequoia 15.3.2
Browser: Chrome 135
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure form is visible when blocking an IP within an existing blocked range with MultiBlocks disabled

  1. Disable MultiBlocks ($wgEnableMultiBlocks = false) on the wiki.
  2. Log in as an admin user with permission to block users.
  3. Navigate to Special:Block.
  4. Block the IP range '127.0.0.1/16'.
  5. After the block is created, attempt to block the individual IP '127.0.0.20'.
  6. ✅ AC1: Confirm that the Special:Block form displays correctly and allows setting a new block on '127.0.0.20'.
IP Range Blockw/IP Block within Range- Yes Add BlockDifferent IP range blocks not within same range- Yes Add BlockIP Ranges blocks within each other- No Add Block
2025-04-29_08-42-14.mp4.gif (820×1 px, 3 MB)
2025-04-29_08-54-12.mp4.gif (822×1 px, 1 MB)
2025-04-29_09-59-15.mp4.gif (822×1 px, 1 MB)

Test Case 2: Verify correct behavior when blocking an IP within an existing blocked range with MultiBlocks enabled

  1. Enable MultiBlocks ($wgEnableMultiBlocks = true) on the wiki.
  2. Log in as an admin user with permission to block users.
  3. Navigate to Special:Block.
  4. Block the IP range '127.0.0.1/16'.
  5. After the block is created, attempt to block the individual IP '127.0.0.20'.
  6. ✅ AC2: Confirm that the Special:Block form displays correctly, allowing the admin to create an overlapping block on '127.0.0.20' without errors.
MB= True
{F59524271}
GMikesell-WMF closed this task as Resolved.Tue, Apr 29, 5:08 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits