Page MenuHomePhabricator
Create Task
Maniphest T392078

Fix broken parsoid grafana dashboards
Open, HighPublic
Actions

Description

After using statslib there are some dashboard that don't show up the right numbers.
More specifically

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.22.0-a4mediawiki/vendormaster+1 K -5 K
Use histogram metrics instead of fake timingsmediawiki/services/parsoidmaster+148 -9
Abstract observe histogram in SiteConfigmediawiki/coremaster+27 -0
Customize query in gerrit

Event Timeline

Jgiannelos created this task.Apr 16 2025, 12:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2025, 12:31 PM
ssastry moved this task from Backlog to Observability on the Parsoid-Read-Views (Performance) board.Apr 17 2025, 8:42 PM
Jgiannelos added a comment.Apr 25 2025, 10:13 AM

Histogram metric type is now available: gerrit.wikimedia.org/r/c/mediawiki/core/+/1063065
It looks like the problem is that we were using timings to workaround the lack of the metric type but the buckets skewed the results.

Jgiannelos claimed this task.Apr 25 2025, 10:14 AM
gerritbot added a comment.Apr 28 2025, 10:00 AM

Change #1139423 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/services/parsoid@master] WIP: Add histogram util and send histogram metrics

https://gerrit.wikimedia.org/r/1139423

gerritbot added a project: Patch-For-Review.Apr 28 2025, 10:00 AM
Jgiannelos moved this task from Backlog to In Progress on the Content-Transform-Team (Work In Progress) board.Apr 28 2025, 10:01 AM
gerritbot added a comment.Apr 28 2025, 10:07 AM

Change #1139425 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/core@master] WIP: Abstract observe histogram

https://gerrit.wikimedia.org/r/1139425

MSantos added a project: OKR-Work.May 5 2025, 12:56 PM
gerritbot added a comment.May 19 2025, 11:01 PM

Change #1139425 merged by jenkins-bot:

[mediawiki/core@master] Abstract observe histogram in SiteConfig

https://gerrit.wikimedia.org/r/1139425

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 20 2025, 12:00 AM
ssastry triaged this task as High priority.May 22 2025, 5:58 PM
gerritbot added a comment.May 23 2025, 8:41 PM

Change #1139423 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Use histogram metrics instead of fake timings

https://gerrit.wikimedia.org/r/1139423

Maintenance_bot removed a project: Patch-For-Review.May 23 2025, 9:30 PM
gerritbot added a comment.May 26 2025, 8:37 PM

Change #1150766 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a4

https://gerrit.wikimedia.org/r/1150766

gerritbot added a project: Patch-For-Review.May 26 2025, 8:37 PM
gerritbot added a comment.May 26 2025, 9:06 PM

Change #1150766 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a4

https://gerrit.wikimedia.org/r/1150766

Maintenance_bot removed a project: Patch-For-Review.May 26 2025, 9:30 PM
Jgiannelos moved this task from In Progress to To Verify on the Content-Transform-Team (Work In Progress) board.May 27 2025, 2:17 PM
MSantos moved this task from Needs Triage to Performance on the Parsoid board.May 29 2025, 2:45 PM
MSantos removed a project: Parsoid.
cscott reassigned this task from Jgiannelos to ssastry.Nov 3 2025, 4:16 PM
ssastry removed ssastry as the assignee of this task.Mar 10 2026, 5:53 PM
ssastry moved this task from To Verify to Needs Investigation on the Content-Transform-Team (Work In Progress) board.
ssastry subscribed.

The wt2html dashboard is still broken. Just one example: there is no way parsoid's mean wt2html output size is 80mb or mean input wt2html size is 11mb. I am sure the html2wt dashboard has issues as well, but haven't investigated. Moving it back to 'needs investigation' and unassigning myself for now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits