Page MenuHomePhabricator
Create Task
Maniphest T392172

1.45.0-wmf.2 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jnuche
Release Version
1.45.0-wmf.2
Release Date
May 19 2025, 12:00 AM

2025 week 21 1.45-wmf.2 Changes wmf/1.45.0-wmf.2

This MediaWiki Train Deployment is scheduled for the week of Monday, May 19th:

Monday May 19thTuesday, May 20thWednesday, May 21stThursday, May 22ndFriday
Backports only.Branch wmf.2 and deploy to Group 0 Wikis.Deploy wmf.2 to Group 1 Wikis.Deploy wmf.2 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.2 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.45.0-wmf.1
Next: 1.45.0-wmf.3
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
group2 to 1.45.0-wmf.2operations/mediawiki-configmaster+348 -348
group1 to 1.45.0-wmf.2operations/mediawiki-configmaster+560 -560
group0 to 1.45.0-wmf.2operations/mediawiki-configmaster+140 -140
testwikis to 1.45.0-wmf.2operations/mediawiki-configmaster+3 -3
Branch commit for wmf/1.45.0-wmf.2mediawiki/corewmf/1.45.0-wmf.2+1 K -3
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Apr 17 2025, 12:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2025, 12:26 AM
thcipriani assigned this task to Aklapper.Apr 17 2025, 12:29 AM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jnuche.
thcipriani set the point value for this task to 5.
thcipriani added projects: Release-Engineering-Team (Priority Backlog 📥), Essential-Work.
thcipriani renamed this task from 1.45.0-wmf.4 deployment blockers to 1.45.0-wmf.3 deployment blockers.Apr 17 2025, 6:01 PM
thcipriani changed Release Version from 1.45.0-wmf.4 to 1.45.0-wmf.3.
thcipriani renamed this task from 1.45.0-wmf.3 deployment blockers to 1.45.0-wmf.2 deployment blockers.May 5 2025, 9:48 PM
thcipriani changed Release Version from 1.45.0-wmf.3 to 1.45.0-wmf.2.
bwang mentioned this in T394328: Verify 1.45.0-wmf.2 deployment.May 14 2025, 4:13 PM
SecurityPatchBot reopened subtask T392976: CVE-2025-53481: Denial of service vector on ipinfo/v0/norevision as Open.May 16 2025, 11:52 PM
SecurityPatchBot added a subtask: T392976: CVE-2025-53481: Denial of service vector on ipinfo/v0/norevision.
SecurityPatchBot mentioned this in T392976: CVE-2025-53481: Denial of service vector on ipinfo/v0/norevision.
Dreamy_Jazz removed a subtask: T392976: CVE-2025-53481: Denial of service vector on ipinfo/v0/norevision.May 19 2025, 1:54 PM
Jgiannelos mentioned this in T394697: CTT tasks week of 2025-05-16.May 19 2025, 4:24 PM
gerritbot added a comment.May 20 2025, 1:08 AM

Change #1147906 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.45.0-wmf.2] Branch commit for wmf/1.45.0-wmf.2

https://gerrit.wikimedia.org/r/1147906

gerritbot added a project: Patch-For-Review.May 20 2025, 1:08 AM
gerritbot added a comment.May 20 2025, 1:18 AM

Change #1147906 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.2] Branch commit for wmf/1.45.0-wmf.2

https://gerrit.wikimedia.org/r/1147906

Maintenance_bot removed a project: Patch-For-Review.May 20 2025, 1:30 AM
gerritbot added a comment.May 20 2025, 3:01 AM

Change #1147915 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis to 1.45.0-wmf.2

https://gerrit.wikimedia.org/r/1147915

gerritbot added a project: Patch-For-Review.May 20 2025, 3:01 AM

Change #1147915 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis to 1.45.0-wmf.2

https://gerrit.wikimedia.org/r/1147915

Stashbot added a comment.May 20 2025, 3:02 AM

Mentioned in SAL (#wikimedia-operations) [2025-05-20T03:02:54Z] <mwpresync@deploy1003> Started scap sync-world: testwikis to 1.45.0-wmf.2 refs T392172

Maintenance_bot removed a project: Patch-For-Review.May 20 2025, 3:30 AM
Stashbot added a comment.May 20 2025, 3:53 AM

Mentioned in SAL (#wikimedia-operations) [2025-05-20T03:53:45Z] <mwpresync@deploy1003> Finished scap sync-world: testwikis to 1.45.0-wmf.2 refs T392172 (duration: 50m 50s)

Aklapper edited projects, added Release-Engineering-Team (Doing 😎); removed Release-Engineering-Team (Priority Backlog 📥).May 20 2025, 7:20 AM
gerritbot added a comment.May 20 2025, 8:11 AM

Change #1148266 had a related patch set uploaded (by TrainBranchBot; author: Andre Klapper):

[operations/mediawiki-config@master] group0 to 1.45.0-wmf.2

https://gerrit.wikimedia.org/r/1148266

gerritbot added a project: Patch-For-Review.May 20 2025, 8:11 AM

Change #1148266 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 to 1.45.0-wmf.2

https://gerrit.wikimedia.org/r/1148266

Stashbot added a comment.May 20 2025, 8:30 AM

Mentioned in SAL (#wikimedia-operations) [2025-05-20T08:30:18Z] <aklapper@deploy1003> rebuilt and synchronized wikiversions files: group0 to 1.45.0-wmf.2 refs T392172

Maintenance_bot removed a project: Patch-For-Review.May 20 2025, 8:30 AM
gerritbot added a comment.May 21 2025, 8:13 AM

Change #1148800 had a related patch set uploaded (by TrainBranchBot; author: Andre Klapper):

[operations/mediawiki-config@master] group1 to 1.45.0-wmf.2

https://gerrit.wikimedia.org/r/1148800

gerritbot added a project: Patch-For-Review.May 21 2025, 8:13 AM

Change #1148800 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 to 1.45.0-wmf.2

https://gerrit.wikimedia.org/r/1148800

Stashbot added a comment.May 21 2025, 8:23 AM

Mentioned in SAL (#wikimedia-operations) [2025-05-21T08:23:31Z] <aklapper@deploy1003> rebuilt and synchronized wikiversions files: group1 to 1.45.0-wmf.2 refs T392172

Aklapper added a subtask: T394891: Syntax Highlighting unavailable on Wikisources in Page namespace: Unsupported CodeMirror mode '' [Called from MediaWiki\Extension\CodeMirror\Hooks::loadCodeMirrorOnEditPage in CodeMirror/includes/Hooks.php at line 223].May 21 2025, 8:28 AM
Maintenance_bot removed a project: Patch-For-Review.May 21 2025, 8:31 AM
Ladsgroup subscribed.May 21 2025, 3:08 PM
• MusikAnimal subscribed.May 22 2025, 3:22 AM

Could we confirm T394891 is a blocker? I don't think it is, but I can get the fix backported if anyone disagrees. CodeMirror has been broken in prod for weeks, but only for the CodeMirror 6 beta feature + Wikisource and only for the Page namespace. While the PHP warning isn't great, I don't think the user ever sees it. To my knowledge there have been no user reports of this issue.

Aklapper added a comment.May 22 2025, 3:49 AM

I'm fine removing it as a blocker. I set it as a blocker right after the group1 deployment yesterday, in the following hours it became clearer that it's less visible than I was initially afraid of (restricted to one namespace, not a huge number of hits in Logstash, now the statement that CodeMirror has been broken for a while and that it only affects the beta feature). Thanks for the additional context! <3

Aklapper removed a subtask: T394891: Syntax Highlighting unavailable on Wikisources in Page namespace: Unsupported CodeMirror mode '' [Called from MediaWiki\Extension\CodeMirror\Hooks::loadCodeMirrorOnEditPage in CodeMirror/includes/Hooks.php at line 223].May 22 2025, 3:49 AM
Aklapper mentioned this in T394891: Syntax Highlighting unavailable on Wikisources in Page namespace: Unsupported CodeMirror mode '' [Called from MediaWiki\Extension\CodeMirror\Hooks::loadCodeMirrorOnEditPage in CodeMirror/includes/Hooks.php at line 223].
gerritbot added a comment.May 22 2025, 8:08 AM

Change #1149327 had a related patch set uploaded (by TrainBranchBot; author: Andre Klapper):

[operations/mediawiki-config@master] group2 to 1.45.0-wmf.2

https://gerrit.wikimedia.org/r/1149327

gerritbot added a project: Patch-For-Review.May 22 2025, 8:08 AM

Change #1149327 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 to 1.45.0-wmf.2

https://gerrit.wikimedia.org/r/1149327

Stashbot added a comment.May 22 2025, 8:18 AM

Mentioned in SAL (#wikimedia-operations) [2025-05-22T08:18:59Z] <aklapper@deploy1003> rebuilt and synchronized wikiversions files: group2 to 1.45.0-wmf.2 refs T392172

Aklapper closed this task as Resolved.May 22 2025, 10:47 AM
Aklapper removed a project: Patch-For-Review.

This looks fine.

brennen mentioned this in T395045: UploadStashFileNotFoundException: Key [file].jpg not found in stash. (via Special:Upload tryagain feature).May 22 2025, 3:15 PM
Daimona mentioned this in T394754: Error while enabling event registration: Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'event_type' in 'INSERT INTO' Function: MediaWiki\Extension\CampaignEvents\Event\Store\EventStore::saveRegistration Query: INSERT INTO `campaign_events` (event_name,event.May 26 2025, 5:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits