Maniphest T392205

EventBus: replace PageDeleteCompleteHook with PageDeletedListener
Closed, ResolvedPublic
Actions

Description

This task introduces basic support for the Domain Events API in EventBus.

AC:

PageDeleteCompleteHook has been replaced with with PageDeletedListener

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	page_change: remove page deletion hooks	mediawiki/extensions/EventBus	master	+1 -64
	PageChangeEventSerializer: serialize PageIdentity	mediawiki/extensions/EventBus	master	+142 -107
	PageChangeEmissionTest: assert on id of deleted page	mediawiki/extensions/EventBus	master	+11 -8
	adopt PageDeleted domain event	mediawiki/extensions/EventBus	master	+163 -8
	add test cases for delete events	mediawiki/extensions/EventBus	master	+18 -9

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		gmodena	T391254 Hypothesis 5.2.13: EventBus Adoption of Domain Events
		Resolved		gmodena	T392205 EventBus: replace PageDeleteCompleteHook with PageDeletedListener

Event Timeline

gmodena created this task.Apr 17 2025, 10:22 AM

gmodena moved this task from Next Up to In progress on the Data-Engineering (Q4 2025 April 1st - June 30th) board.

HCoplin-WMF moved this task from Now to Supporting on the MW-Interfaces-Team (MWI-Roadmap) board.Apr 24 2025, 2:33 PM

Change #1140480 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] adopt PageDeleted domain event

https://gerrit.wikimedia.org/r/1140480

gerritbot added a project: Patch-For-Review.May 1 2025, 9:51 AM

Change #1143055 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] add integration test for PageUpdated event

https://gerrit.wikimedia.org/r/1143055

While working on this we've learn that it's currently not (easily) possible to serialize target link redirect from a PageDeleted event.

See T393633: PageDeleted event should contain outgoing redirect target information (patch in flight).

gmodena moved this task from In progress to In Review on the Data-Engineering (Q4 2025 April 1st - June 30th) board.May 13 2025, 8:06 AM

Change #1143055 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] add test cases for delete events

https://gerrit.wikimedia.org/r/1143055

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 14 2025, 11:00 PM

Change #1148832 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] page_change: remove page deletion hooks

https://gerrit.wikimedia.org/r/1148832

Change #1140480 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] adopt PageDeleted domain event

https://gerrit.wikimedia.org/r/1140480

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 26 2025, 2:00 PM

Change #1154232 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] PageChangeEmissionTest: assert on id of deleted page

https://gerrit.wikimedia.org/r/1154232

Change #1155233 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] PageChangeEventSerializer: serialize PageIdentity

https://gerrit.wikimedia.org/r/1155233

Change #1154232 abandoned by Gmodena:

[mediawiki/extensions/EventBus@master] PageChangeEmissionTest: assert on id of deleted page

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventBus/+/1155233

https://gerrit.wikimedia.org/r/1154232

gmodena moved this task from In Review to Done on the Data-Engineering (Q4 2025 April 1st - June 30th) board.Jun 11 2025, 8:51 AM

Change #1155233 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] PageChangeEventSerializer: serialize PageIdentity

https://gerrit.wikimedia.org/r/1155233

Change #1148832 abandoned by Gmodena:

[mediawiki/extensions/EventBus@master] page_change: remove page deletion hooks

Reason:

Superseded by 1163344

https://gerrit.wikimedia.org/r/1148832

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2025, 12:31 PM

Ahoelzl closed this task as Resolved.Jul 25 2025, 11:06 PM

Umherirrender mentioned this in T400380: MediaWiki\Revision\RevisionAccessException: Unable to load fresh row for rev_id: {rev_id}.Aug 28 2025, 7:35 PM