Page MenuHomePhabricator
Create Task
Maniphest T392300

CiviCRM Message Templates: "Draft" version being sent instead of "Active"
Closed, ResolvedPublic
Actions

Description

Summary:
CiviCRM is sending the Draft version of message templates to donors instead of the Active version. This issue was first noticed with the “WMF Thank You (English - United States)” template but may affect all message templates.

Interim solution:
To prevent this from continuing, I've abandoned drafts from templates:

  • WMF Thank You (English - United States)
  • WMF Monthly convert (English - United States)

Expected Behavior
CiviCRM should be sending the Active and not the Draft version of a message template,

Examples:
Under the "Recent thank yous" view, activities with ID:

  • 242631076
  • 242630877
  • 242630507

are examples of donors receiving the Draft version.

After discarding the drafts, it appears that starting from ID 242631189 onward, donors have been receiving the correct Active version of the message template.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Select active translation in API4 wrapper, not draftEjeggwikimedia/fundraising/crmmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

ppenloglou created this task.Apr 18 2025, 3:26 PM
Restricted Application added a project: Fundraising-Backlog. · View Herald TranscriptApr 18 2025, 3:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ppenloglou updated the task description. (Show Details)Apr 18 2025, 3:26 PM
Cstone added a subscriber: Eileenmcnaughton.Apr 18 2025, 3:53 PM
XenoRyet triaged this task as High priority.Apr 21 2025, 7:20 PM
Cstone moved this task from Backlog to User Bug Backlog on the Fundraising Tech - Chaos Crew board.Apr 21 2025, 7:23 PM
Ejegg subscribed.Apr 23 2025, 3:28 PM

I can reproduce this in development, and am trying to figure out where this behavior started. Unfortunately I've gotten all the way back to commit 666759ad72ced9d9faef11a6e9cf9fce43face55 from last April and it's still sending the draft version.

Ejegg added a comment.Apr 23 2025, 3:55 PM

Back to 5f31fb9d193708e8d0dc8ca7f602531fee0475ff from September 2023 and still seeing the bug :S

AKanji-WMF moved this task from Triage to FR-Ops on the Fundraising-Backlog board.Apr 23 2025, 5:20 PM
AKanji-WMF moved this task from FR-Ops to Chaos Crew Backlog on the Fundraising-Backlog board.
Eileenmcnaughton added a comment.Apr 23 2025, 7:32 PM

@Ejegg originally no one actually used the draft feature so it probably worked by virtue of there being no drafts...

ppenloglou added a comment.May 14 2025, 9:23 AM

Hi team! Wondering about the status on this one? Thanks!

TomaszGorski subscribed.May 20 2025, 1:28 PM
gerritbot added a comment.May 21 2025, 7:13 PM

Change #1148910 had a related patch set uploaded (by Damilare Adedoyin; author: Ejegg):

[wikimedia/fundraising/crm@master] Select active translation in API4 wrapper, not draft

https://gerrit.wikimedia.org/r/1148910

gerritbot added a project: Patch-For-Review.May 21 2025, 7:13 PM
Ejegg moved this task from User Bug Backlog to Ready for Review on the Fundraising Tech - Chaos Crew board.May 21 2025, 11:32 PM
gerritbot added a comment.May 22 2025, 12:02 PM

Change #1148910 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Select active translation in API4 wrapper, not draft

https://gerrit.wikimedia.org/r/1148910

Maintenance_bot removed a project: Patch-For-Review.May 22 2025, 12:30 PM
Ejegg moved this task from Ready for Review to Done on the Fundraising Tech - Chaos Crew board.May 22 2025, 5:49 PM
In T392300#10820836, @ppenloglou wrote:

Hi team! Wondering about the status on this one? Thanks!

Hi @ppenloglou , we've just deployed a fix for this to production. I'd like to find some time to validate it by turning the TY mailer off for a bit, creating a TY draft, then sending a single mail to confirm that it doesn't send the draft version.

ppenloglou added a comment.May 26 2025, 11:18 AM

Hey @Ejegg , thank you for the update! Okay we'll sit tight and make sure the fix is good to go before we continue working on Civi mailings. Appreciate your hard work 🛠️

Ejegg added a comment.May 26 2025, 4:52 PM

@ppenloglou I've just run that test and verified that it sends the active and not the draft email. We should be good to use drafts from now on.

Ejegg closed this task as Resolved.May 26 2025, 5:04 PM
Ejegg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits