The two following methods in SiteConfiguration seems to have duplicate code:

• SiteConfiguration::extractGlobalSetting()
• SiteConfiguration::getAll()

They both check if a variable starts with '+', eventually merge array or just set the value. The only difference is that the first one write the result in $_GLOBALS;

Considering what we have in production:

globals = $conf->getAll( 'enwiki' );
extract( $globals );

That could be replaced by:

$conf->extractAllGlobals( 'enwiki' );

Actually, since both methods seems to be duplicates, we are not sure the two use cases are going to do EXACTLY the same thing. Hence this request to factor out both methods.

Version: 1.20.x
Severity: normal