Page MenuHomePhabricator
Create Task
Maniphest T392412

Migrate static hook handlers in WikibaseClient to use HookRunner pattern
Closed, ResolvedPublic
Actions

Description

As a follow-up to T391442, there are still some hooks in extension-client.json that use static methods. Migrate these to use constructible classes, implementing the associated hook interfaces if they exist.

Acceptance Criteria

  • All hooks in the Hooks section of Wikibase's extension-client.json reference HookHandlers
  • For all hooks that have a hook interface, the hook handler classes implement the interface

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

ArthurTaylor created this task.Apr 22 2025, 7:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 22 2025, 7:30 AM
ArthurTaylor added parent tasks: T381172: [EPIC] Update all WMDE Wikibase topics to use the new HookContainer/HookRunner system, T338452: Update Wikibase to use the new HookContainer/HookRunner system.Apr 22 2025, 7:31 AM
ArthurTaylor mentioned this in T391442: Create HookRunner classes and interfaces for Wikibase Client and use them.
ArthurTaylor moved this task from Incoming to The Backlog on the Wikidata-Omega board.
hoo claimed this task.Apr 22 2025, 9:01 AM
hoo moved this task from The Backlog to The Board on the Wikidata-Omega board.
hoo edited projects, added: Wikidata-Omega (The Board); removed: Wikidata-Omega.
hoo moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 22 2025, 1:23 PM
gerritbot added a comment.Apr 23 2025, 5:56 PM

Change #1138427 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Add CirrusSearchAddQueryFeaturesHookHandler

https://gerrit.wikimedia.org/r/1138427

gerritbot added a project: Patch-For-Review.Apr 23 2025, 5:56 PM
gerritbot added a comment.Apr 25 2025, 12:30 PM

Change #1139021 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Migrate Echo related client hook handlers

https://gerrit.wikimedia.org/r/1139021

gerritbot added a comment.May 1 2025, 3:49 PM

Change #1140509 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Move "ScribuntoExternalLibraries" out of ClientHooks

https://gerrit.wikimedia.org/r/1140509

gerritbot added a comment.May 2 2025, 9:24 AM

Change #1140649 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/WikibaseLexeme@master] Lua: Make mw.wikibase.lexeme init more robust

https://gerrit.wikimedia.org/r/1140649

gerritbot added a comment.May 2 2025, 9:31 AM

Change #1140651 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Lua: Make mw.wikibase init more robust

https://gerrit.wikimedia.org/r/1140651

gerritbot added a comment.May 4 2025, 11:20 AM

Change #1138427 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add CirrusSearchAddQueryFeaturesHookHandler

https://gerrit.wikimedia.org/r/1138427

gerritbot added a comment.May 4 2025, 11:20 AM

Change #1139021 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate Echo related client hook handlers

https://gerrit.wikimedia.org/r/1139021

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06).May 4 2025, 12:01 PM
gerritbot added a comment.May 6 2025, 7:28 AM

Change #1140649 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Lua: Make mw.wikibase.lexeme init more robust

https://gerrit.wikimedia.org/r/1140649

gerritbot added a comment.May 6 2025, 7:30 AM

Change #1140651 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Lua: Make mw.wikibase init more robust

https://gerrit.wikimedia.org/r/1140651

gerritbot added a comment.May 6 2025, 7:30 AM

Change #1140509 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move "ScribuntoExternalLibraries" out of ClientHooks

https://gerrit.wikimedia.org/r/1140509

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 6 2025, 8:01 AM
Maintenance_bot removed a project: Patch-For-Review.May 6 2025, 8:30 AM
gerritbot added a comment.May 9 2025, 8:41 AM

Change #1143753 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Migrate client SkinAfterBottomScripts hook handler

https://gerrit.wikimedia.org/r/1143753

gerritbot added a project: Patch-For-Review.May 9 2025, 8:41 AM
hoo moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.May 9 2025, 9:19 AM
hoo added a comment.May 9 2025, 9:21 AM

While SkinAfterBottomScripts is ready for review, FormatAutocomments, WikibaseContentLanguages and GetPreferences are still to do. I'll handle them today or on Monday.

Lucas_Werkmeister_WMDE claimed this task.May 9 2025, 2:49 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE added a subscriber: hoo.
gerritbot added a comment.May 12 2025, 1:35 PM

Change #1143753 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move SkinAfterBottomScriptsHook into LinkedDataSchemaGenerator

https://gerrit.wikimedia.org/r/1143753

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.May 12 2025, 1:39 PM
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Ready for Development on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE subscribed.
Maintenance_bot removed a project: Patch-For-Review.May 12 2025, 2:31 PM
Lucas_Werkmeister_WMDE claimed this task.May 12 2025, 3:12 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.May 12 2025, 3:26 PM

Change #1144599 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move FormatAutocomments out of ClientHooks

https://gerrit.wikimedia.org/r/1144599

gerritbot added a project: Patch-For-Review.May 12 2025, 3:26 PM
gerritbot added a comment.May 12 2025, 3:35 PM

Change #1144602 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move GetPreferences out of ClientHooks

https://gerrit.wikimedia.org/r/1144602

gerritbot added a comment.May 12 2025, 3:42 PM

Change #1144603 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move WikibaseContentLanguages out of ClientHooks

https://gerrit.wikimedia.org/r/1144603

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.May 12 2025, 3:42 PM
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.May 12 2025, 3:51 PM

Change #1144604 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move SidebarHookHandler-related code into that class

https://gerrit.wikimedia.org/r/1144604

gerritbot added a comment.May 12 2025, 4:04 PM

Change #1144606 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move linkitem-related code to new LinkItemModuleMethods class

https://gerrit.wikimedia.org/r/1144606

hoo claimed this task.May 12 2025, 4:21 PM
hoo moved this task from Ready for Peer Review to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.May 12 2025, 4:50 PM

Change #1144615 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Migrate FormatAutocommentsHandler

https://gerrit.wikimedia.org/r/1144615

gerritbot added a comment.May 12 2025, 4:57 PM

Change #1144615 abandoned by Hoo man:

[mediawiki/extensions/Wikibase@master] Migrate FormatAutocommentsHandler

Reason:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1144599

https://gerrit.wikimedia.org/r/1144615

hoo removed hoo as the assignee of this task.May 12 2025, 6:01 PM
hoo moved this task from In Development to In Peer Review on the Wikidata-Omega (The Board) board.
hoo moved this task from In Peer Review to Ready for Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.May 13 2025, 10:03 AM

Change #1144599 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate FormatAutocommentsHandler

https://gerrit.wikimedia.org/r/1144599

gerritbot added a comment.May 13 2025, 10:14 AM

Change #1144602 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move GetPreferences out of ClientHooks

https://gerrit.wikimedia.org/r/1144602

gerritbot added a comment.May 13 2025, 10:14 AM

Change #1144603 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move WikibaseContentLanguages out of ClientHooks

https://gerrit.wikimedia.org/r/1144603

matej_suchanek merged a task: T67700: Move hook handlers into own classes (client).May 13 2025, 10:47 AM
matej_suchanek added subscribers: Bene, Michael, Jayprakash12345 and 3 others.
ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20); removed: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 13 2025, 11:00 AM
hoo claimed this task.May 13 2025, 6:12 PM
hoo moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.May 13 2025, 6:49 PM

Change #1144604 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move SidebarHookHandler-related code into that class

https://gerrit.wikimedia.org/r/1144604

gerritbot added a comment.May 14 2025, 10:43 AM

Change #1144606 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move linkitem-related code to new LinkItemModuleMethods class

https://gerrit.wikimedia.org/r/1144606

Lucas_Werkmeister_WMDE removed hoo as the assignee of this task.May 14 2025, 10:46 AM
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.
Maintenance_bot removed a project: Patch-For-Review.May 14 2025, 11:31 AM
karapayneWMDE closed this task as Resolved.May 15 2025, 2:03 PM
karapayneWMDE claimed this task.
karapayneWMDE moved this task from Ready for Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
karapayneWMDE edited projects, added: Wikidata-Omega (Completed Tasks); removed: Wikidata-Omega (The Board).
karapayneWMDE moved this task from Newly completed tasks to 2025 Q2 on the Wikidata-Omega (Completed Tasks) board.
gerritbot added a comment.Mon, May 18, 9:19 AM

Change #1288480 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Hoo man):

[mediawiki/extensions/WikibaseLexeme@REL1_43] Lua: Make mw.wikibase.lexeme init more robust

https://gerrit.wikimedia.org/r/1288480

gerritbot added a project: Patch-For-Review.Mon, May 18, 9:19 AM
gerritbot added a comment.Mon, May 18, 1:46 PM

Change #1288480 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@REL1_43] Lua: Make mw.wikibase.lexeme init more robust

https://gerrit.wikimedia.org/r/1288480

Maintenance_bot removed a project: Patch-For-Review.Mon, May 18, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits