Page MenuHomePhabricator

Replace jquery function .fail() with jquery .catch() in the showIp.js module.
Closed, ResolvedPublic

Description

Replace .fail() with .catch() in the showIp.js module.
See comment here.

Acceptance Criteria:

  • .fail() replaced with .catch()
  • showIp functionality still works

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Change #1171565 had a related patch set uploaded (by Anirudh_K; author: Anirudh_K):

[mediawiki/extensions/PageTriage@master] T392527: Replace jQuery .fail() with .catch() in showIp.js module

https://gerrit.wikimedia.org/r/1171565

I assigned this to myself and made the change.
Replaced .fail() with .catch() in getTempAccountUserIpAddress() to fix the deprecated jQuery usage.
It should works fine now.

Please review. here- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/1171565

Change #1171565 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Replace jQuery .fail() with .catch() in showIp.js module

https://gerrit.wikimedia.org/r/1171565

The issue has been successfully resolved on my end.
Requesting you to please close the task. Thank you!