Page MenuHomePhabricator
Create Task
Maniphest T392592

Translate should use NotificationMiddleware instead of AbortEmailNotification hook
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The translate extension uses AbortEmailNotification, which removes Watchlist notifications from Translate.

Instead of using AbortEmailNotification it should use the introduced Middleware pattern that will allow filtering notifications.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Re-apply "Use middleware instead of AbortEmailNotification hook"mediawiki/extensions/Translatemaster+100 -12
Revert "Use middleware instead of AbortEmailNotification hook"mediawiki/extensions/Translatemaster+11 -97
Use middleware instead of AbortEmailNotification hookmediawiki/extensions/Translatemaster+97 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

pmiazga created this task.Apr 24 2025, 2:17 PM
gerritbot added a comment.Apr 24 2025, 2:42 PM

Change #1138814 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/extensions/Translate@master] Use middleware instead of AbortEmailNotification hook

https://gerrit.wikimedia.org/r/1138814

gerritbot added a project: Patch-For-Review.Apr 24 2025, 2:42 PM
pmiazga moved this task from Backlog to In progress on the MediaWiki-Core-Notifications board.May 9 2025, 1:15 PM
pmiazga renamed this task from HOLD: Translate should use NotificationMiddleware instead of AbortEmailNotification hook to Translate should use NotificationMiddleware instead of AbortEmailNotification hook.May 27 2025, 4:43 PM
pmiazga edited parent tasks, added: T389618: Deprecate `AbortEmailNotification` hook; removed: T383996: Migrate Enotif to the new notifications interface.
• matmarex assigned this task to pmiazga.Jun 7 2025, 12:28 AM
abi_ triaged this task as Medium priority.Jun 9 2025, 10:34 AM
abi_ added a project: LPL Essential (LPL Essential 2025 Apr-Jun: CX).
abi_ set the point value for this task to 1.
abi_ moved this task from Backlog to In Progress on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.
gerritbot added a comment.Jun 10 2025, 8:41 AM

Change #1138814 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Use middleware instead of AbortEmailNotification hook

https://gerrit.wikimedia.org/r/1138814

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.6; 2025-06-17).Jun 10 2025, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 10 2025, 9:31 AM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.Jun 16 2025, 2:43 AM
abi_ closed this task as Resolved.Jun 16 2025, 3:45 AM
abi_ moved this task from Pending Deployment to Done on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.
abi_ subscribed.

This change has been deployed and tested on translatewiki.net. I've reviewing a bunch of translations, but haven't received any notification.

gerritbot added a comment.Jul 21 2025, 7:39 PM

Change #1171266 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Translate@master] Revert "Use middleware instead of AbortEmailNotification hook"

https://gerrit.wikimedia.org/r/1171266

gerritbot added a project: Patch-For-Review.Jul 21 2025, 7:39 PM
• matmarex reopened this task as Open.Jul 21 2025, 7:39 PM
• matmarex subscribed.
gerritbot added a comment.Jul 21 2025, 8:03 PM

Change #1171266 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Revert "Use middleware instead of AbortEmailNotification hook"

https://gerrit.wikimedia.org/r/1171266

gerritbot added a comment.Jul 21 2025, 8:08 PM

Change #1169240 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Translate@master] Re-apply "Use middleware instead of AbortEmailNotification hook"

https://gerrit.wikimedia.org/r/1169240

• matmarex moved this task from In progress to Blocked / External on the MediaWiki-Core-Notifications board.Jul 22 2025, 2:17 AM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptJul 22 2025, 2:17 AM
• matmarex moved this task from Inbox, needs triage to Waiting on the MediaWiki-Platform-Team board.Jul 22 2025, 2:19 AM
gerritbot added a comment.Aug 13 2025, 1:08 PM

Change #1169240 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Re-apply "Use middleware instead of AbortEmailNotification hook"

https://gerrit.wikimedia.org/r/1169240

Maintenance_bot removed a project: Patch-For-Review.Aug 13 2025, 1:31 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.15; 2025-08-19); removed MW-1.45-notes (1.45.0-wmf.6; 2025-06-17).Aug 13 2025, 2:00 PM
• matmarex closed this task as Resolved.Aug 13 2025, 2:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits