Page MenuHomePhabricator
Create Task
Maniphest T392722

Change the Wikifunctions insert dialog link to open in a new tab
Closed, ResolvedPublic
Actions

Description

Steps:

  • In VE click on Insert, select Wikifunciton option
  • In the insert function dialog, click on the link "Funciton from Wikifuncitons"

<span class="ext-wikilambda-app-function-input-setup__link"><a title="F:Z10000" href="/wiki/F:Z10000">Function</a> from Wikifunctions</span>

  • The warning appears alerting users they are about to leave a page:

Screen Shot 2025-04-22 at 5.18.39 PM.png (1×1 px, 320 KB)

Note:

  • all other links that redirect to wikifunctions, work as expected, i.e. a new tab will open.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Open external link in a new tab in the VisualEditor function input setupmediawiki/extensions/WikiLambdamaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Apr 25 2025, 8:14 PM
Etonkovidova attached a referenced file: F59366553: Screen Shot 2025-04-22 at 5.18.39 PM.png. (Show Details)
Etonkovidova mentioned this in T391734: [QA task] testwiki - wikifunctions integration testing.Apr 25 2025, 8:21 PM
DSantamaria triaged this task as Medium priority.Apr 30 2025, 3:44 PM
DSantamaria edited projects, added Abstract Wikipedia team (25Q4 (Apr–Jun)); removed Abstract Wikipedia team.
DSantamaria moved this task from Incoming to Ready on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
DSantamaria edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (25Q4 (Apr–Jun)).May 10 2025, 7:07 PM
DSantamaria moved this task from To Triage to Product Backlog on the Abstract Wikipedia team board.
DSantamaria removed a project: Wikifunctions integration.Nov 24 2025, 2:57 PM
DSmit-WMF added a comment.Nov 28 2025, 1:02 PM

https://phabricator.wikimedia.org/T406155

Etonkovidova added a comment.EditedDec 3 2025, 11:02 PM
In T392722#11415800, @DSmit-WMF wrote:

https://phabricator.wikimedia.org/T406155

@DSmit-WMF - I checked links in the insert template dialog. On the screenshots below all links in the template dialog will open a new tab.

Screenshot 2025-12-03 at 5.02.57 PM.png (1×1 px, 247 KB)

Another thing I noticed when re-checking this ticket on testwiki wmf.5 - the Console error Uncaught (in promise) ApiError: Request was aborted is displayed when anything is typed in the cdx-text-input__input, the search text field for wikifunctions:

Screenshot 2025-12-03 at 5.09.44 PM.png (1×2 px, 385 KB)

Each new attempt to type will trigger the same error as above.

DSmit-WMF added a comment.EditedDec 4 2025, 12:14 PM

I have addressed this in a patch (both) coming up

gerritbot added a comment.Dec 4 2025, 12:22 PM

Change #1215136 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Open external link in a new tab in the VisualEditor function input setup

https://gerrit.wikimedia.org/r/1215136

gerritbot added a project: Patch-For-Review.Dec 4 2025, 12:22 PM
DSmit-WMF added a comment.Dec 4 2025, 12:22 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1215136

and

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1215135

DSmit-WMF changed the task status from Open to In Progress.Dec 4 2025, 12:23 PM
DSmit-WMF claimed this task.
DSmit-WMF moved this task from Product Backlog to 26Q2 (Oct–Dec) on the Abstract Wikipedia team board.
DSmit-WMF edited projects, added Abstract Wikipedia team (26Q2 (Oct–Dec)); removed Abstract Wikipedia team.
DSmit-WMF moved this task from Incoming to In Code review on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.
DSantamaria added a project: Essential-Work.Dec 9 2025, 6:35 AM
Jdforrester-WMF renamed this task from Wikifunction insert dialog link opens in the same tab to Change the Wikifunctions insert dialog link to opens in a new tab.Dec 9 2025, 4:50 PM
Jdforrester-WMF renamed this task from Change the Wikifunctions insert dialog link to opens in a new tab to Change the Wikifunctions insert dialog link to open in a new tab.
Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.
gerritbot added a comment.Dec 9 2025, 5:01 PM

Change #1215136 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Open external link in a new tab in the VisualEditor function input setup

https://gerrit.wikimedia.org/r/1215136

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2025, 5:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Dec 9 2025, 6:00 PM
DSantamaria moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.Dec 19 2025, 8:25 AM
DSmit-WMF closed this task as Resolved.Dec 19 2025, 10:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits