Page MenuHomePhabricator

Data:.chart pages should preview showing the user language and ?uselang=
Closed, ResolvedPublic

Description

While poking at T383482 it looks like folks would like to be able to preview Data:.chart pages in their user language, and be able to override it with ?uselang=.

Supporting this is not super difficult, and is easier if we pass the locale param from the renderer out into a <wiki-chart lang="XX"> attribute. This is a small one-line change to each of the chart-renderer and Chart's client-side JS.

This would also provide the necessary backend support for making language localization overridable on an individual invocation basis within a page.

Acceptance criteria:

  • <wiki-chart> wrapper element should have a lang attribute that matches its localization
    • this allows any potential uses that don't match the surrounding page!
  • ?uselang=XX should set the localization for the preview rendering on Data:.chart pages, as on Data:.tab pages
  • the above should apply to both localized strings and formatting

Event Timeline

Change #1139128 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/Chart@master] Support per-chart language for preview pages, etc

https://gerrit.wikimedia.org/r/1139128

Change #1139132 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/Chart@master] Render Data:.chart page reviews in user language

https://gerrit.wikimedia.org/r/1139132

Change #1139128 merged by jenkins-bot:

[mediawiki/extensions/Chart@master] Support per-chart language for preview pages, etc

https://gerrit.wikimedia.org/r/1139128

Change #1139132 merged by jenkins-bot:

[mediawiki/extensions/Chart@master] Render Data:.chart page reviews in user language

https://gerrit.wikimedia.org/r/1139132

Change #1147059 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/Chart@wmf/1.45.0-wmf.1] Render Data:.chart page reviews in user language

https://gerrit.wikimedia.org/r/1147059

Change #1147059 merged by jenkins-bot:

[mediawiki/extensions/Chart@wmf/1.45.0-wmf.1] Render Data:.chart page reviews in user language

https://gerrit.wikimedia.org/r/1147059

Mentioned in SAL (#wikimedia-operations) [2025-05-19T16:42:08Z] <bvibber@deploy1003> Started scap sync-world: Backport for [[gerrit:1147059|Render Data:.chart page reviews in user language (T392725)]]

Mentioned in SAL (#wikimedia-operations) [2025-05-19T16:46:29Z] <bvibber@deploy1003> bvibber: Backport for [[gerrit:1147059|Render Data:.chart page reviews in user language (T392725)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-05-19T16:54:03Z] <bvibber@deploy1003> Finished scap sync-world: Backport for [[gerrit:1147059|Render Data:.chart page reviews in user language (T392725)]] (duration: 11m 54s)

@bvibber Is there anything left on this task, or is this done? Could you close it if so?

bvibber claimed this task.

Looks like all the bits of this are deployed and working. Closing out as resolved :D