Page MenuHomePhabricator

Popover: icon may shrink when space is limited in the header
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Navigate to the config demo on the main branch at https://doc.wikimedia.org/codex/main/components/demos/popover.html
  • In the configurable demo, add a long title like “Popover title is very very very very very very very very long”, and add an icon such as 'cdxIconAppearance' and the close button.
  • Use the appearance menu in the header to change the font size to "Extra Large"

What happens?: The icon has no horizontal space to grow and scale with font size in larger font modes. This is due to the default flex-shrink behavior.

Popover - font modes bug shrinks icon.png (3,222×1,910 px, 855 KB)

What should have happened instead?: The icon should not shrink. Its width should allow it to grow and scale with font modes.

Popover - font modes bug expected behavior.png (3,198×1,366 px, 644 KB)

Software version : Codex main branch


Acceptance Criteria

  • Ensure the Popover header icon doesn't shrink when space is limited, for example, long titles and larger font modes.

Event Timeline

lwatson set the point value for this task to 1.

Change #1139133 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] Popover, styles: ensure header icon does not shrink

https://gerrit.wikimedia.org/r/1139133

Change #1139133 merged by jenkins-bot:

[design/codex@main] Popover, styles: ensure header icon does not shrink

https://gerrit.wikimedia.org/r/1139133

Change #1139942 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v1.23.0 to 2.0.0-rc.1

https://gerrit.wikimedia.org/r/1139942

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/f82f2e0c2b/w/

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/f82f2e0c2b/w/

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/e49103389b/w/

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/e49103389b/w/

Change #1139942 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.23.0 to 2.0.0-rc.1

https://gerrit.wikimedia.org/r/1139942

AnneT updated the task description. (Show Details)

Test wiki on Patch demo by 1Esk19 using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/ffa0e13429/w/