Page MenuHomePhabricator

Unable to access the revision-deletion interface from Special:Log - an "Invalid target revision" error page is displayed
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue

  • Log in to a wiki as an account with delete, deleterevision, deletedhistory and deletelogentry rights.
  • Navigate to Special:Log.
  • Select the checkboxes next to any of the listed log events, and click "Change visibility of selected log entries".

What happens?
An "Invalid target revision" error page is displayed:

screenshot.png (755×1 px, 59 KB)

What should have happened instead?
The user is taken to the "Delete/undelete revisions" page for the selected log events.

Software version
mediawiki/core at ee5c229

Other information/Notes
Reproduced locally using MediaWiki-Docker with a MariaDB database.
git bisect tells me this was broken by rMWb9b84e6651af: Switch from mixed Xml and Html classes to pure Html ones in misc code (https://gerrit.wikimedia.org/r/997975) merged on 2025-04-22; cc @Jdforrester-WMF @matmarex for awareness

Details

Related Changes in Gerrit:

Event Timeline

Not gonna change the priority field myself given I filed this task, but I believe this should be fixed as a high priority -- unless I'm missing something, it breaks the ability to (at least easily) revision-delete log entries from the Special:Log interface.

I must have overlooked something in code review, I'll debug this.

taavi triaged this task as Unbreak Now! priority.Apr 28 2025, 4:16 PM
taavi subscribed.

Blocking the ability to delete/suppress things feels like a train blocker to me.

Change #1139512 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Fix RevisionDelete / EditTags checkboxes

https://gerrit.wikimedia.org/r/1139512

Change #1139512 merged by jenkins-bot:

[mediawiki/core@master] Fix RevisionDelete / EditTags checkboxes

https://gerrit.wikimedia.org/r/1139512

The patch made it into wmf.27, no backport is needed.