Page MenuHomePhabricator

Upcoming / Sections do not appear in transluced Event list if including a start date
Closed, ResolvedPublic

Description

Given I am transcluding an event event list
And I include a wpStartDate parameter
Then the Upcoming / Ongoing event sections disappear


Can test with this event which transcludes with the following:
{{Special:AllEvents|wpStartDate=2025-04-23}}

Event Timeline

This has to do with the format used for the start date. 2025-04-23 is not recognized as a valid timestamp format by the Timestamp library. I was under the impression that it would be accepted, but that is not the case (I was misled by a local test case).

One option would be to document the accepted format, and keep transclusion consistent with the special page. However, I don't like this because we require a full timestamp but really the hh:mm:ss part is ignored. We only happen to use full timestamps (in the special page itself) because the "date" input type did not let us implement T365271, and so we had to switch to datetime. But we don't have to expose this everywhere, so I think it would make sense to accept just the day.

Change #1139552 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] SpecialAllEvents: allow date-only date filters when transcluding

https://gerrit.wikimedia.org/r/1139552

Change #1139552 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] SpecialAllEvents: allow date-only date filters when transcluding

https://gerrit.wikimedia.org/r/1139552

this is working correctly now marking as done / resolved