See parent
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Feature | HNordeenWMF | T157364 [FEATURE REQUEST] Tabbed Browsing | ||
| Resolved | HNordeenWMF | T384758 [Epic] Add Tabbed Browsing to the iOS App (Tabs) | |||
| Resolved | HNordeenWMF | T390916 [Sub-Epic] Tabbed Browsing V1 Main Flow & Actions | |||
| Resolved | HNordeenWMF | T391002 [XL] Tabs data infrastructure | |||
| Resolved | Tsevener | T392917 Tabs Data - Call data controller during article navigation |
Event Timeline
Comment Actions
@scblr Per our discussions, can you do a quick check to confirm for me that the back behavior and tabs overview screen displays what you expect? Enable tabs in developer settings on Experimental build 7.7.6 (243).
A few caveats:
- The Main Page grid item UI isn't there yet, but we do have a (mostly) blank space there for you to check the navigation behavior after tapping that cell:
- Note I do not have Random Article in Explore hooked into this flow yet, so don't tap into that. I also have not tested deep links. I think the other main rabbit hole launch points are working (Explore, Search, etc).
- Just temporarily, I added a red border around the "current" tab. I found it helped me with checking the logic.
Please check tapping the Main Page grid item, a tab grid item, and the + button on Tabs overview. Also check article links, article long presses, and article searches. I mainly need to know that it navigates where you expect, that the tabs overview view shows what you expect, and that the back button takes you where you expect. Thank you! 🙏
Comment Actions
Initial PRs:
- https://github.com/wikimedia/wikipedia-ios/pull/5276
- https://github.com/wikimedia/wikipedia-ios/pull/5284.
Remaining work (probably about 1 point):
- Random Article from Explore (this path doesn't use ArticleCoordinator, so it missed out on the initial work).
- Handling deep links
Comment Actions
Re-opening so we can review/QA https://github.com/wikimedia/wikipedia-ios/pull/5289
Test Steps
- Create some tabs, some with multiple articles and some without.
- Terminate the app
- Open the app again and open a tab from tabs overview.
- Check the article more menu - confirm you can reload the article view via tapping the new back and forward options. Confirm these back and forward options hide at the appropriate times when you are at the beginning or end of a tab.
- Navigate to an article in the middle of a tab, then tap a blue link. Confirm old traces of the original rabbit hole are gone.
- For example, if you created a Tab with Cat > Dog > Earth articles, then tapped back to Dog and navigated to Ocean, confirm you cannot navigate to Earth anymore. The new tab's articles should read Cat > Dog > Ocean (Earth is deleted).