See parent
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T157364 [FEATURE REQUEST] Tabbed Browsing | ||
| Resolved | HNordeenWMF | T384758 [Epic] Add Tabbed Browsing to the iOS App (Tabs) | |||
| Resolved | HNordeenWMF | T390916 [Sub-Epic] Tabbed Browsing V1 Main Flow & Actions | |||
| Resolved | HNordeenWMF | T390999 Tabs overview | |||
| Resolved | GOlson-WMF | T392923 Tabs Overview UI - Close Buttons |
Event Timeline
Comment Actions
@GOlson-WMF do the close buttons have a minimum tap target size of 44pt? other than that — looks good to me.
Comment Actions
[not a release blocker, filed in separate task: T396160] Bug I noticed while using Tabs: closing all but one tab leaves tab not tappable in the same session
Steps to reproduce
- On fresh install, open a lot of pages in new tabs
- Open tabs overview
- Close all but one tab
- Try to reopen the single tab
What happens
- Tab can't be opened
- If I leave to article view, and come back to Overview it works.
What should happen
- Tab can open in the same overview session
Comment Actions
[not a release blocker, filed a separate task for this: T396159] Another oddity here that I think is coming from T392925 always trying to show the current tab
Steps to reproduce
- Open a lot of tabs so that it takes up multiple screens
- Open your most recent tab (at the bottom)
- Close a tab towards the top
What happens
- Tabs shuffle up to fill in (as expected)
- The overview jumps to the bottom
What should happen (If possible!)
- Tabs shuffle up to fill in
- Maintain the same scroll position (even though the bottom tab is now your current tab)
On iPad Mini
https://drive.google.com/file/d/1wTGbUh49UHRyn2SRG6pmt_4WKNnRJl_O/view?usp=sharing
Comment Actions
I think this one shouldn't block release, since people can always leave the overview and come back. And probably unlikely people close en masse so frequently.