See parent
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T157364 [FEATURE REQUEST] Tabbed Browsing | ||
| Resolved | HNordeenWMF | T384758 [Epic] Add Tabbed Browsing to the iOS App (Tabs) | |||
| Resolved | HNordeenWMF | T390916 [Sub-Epic] Tabbed Browsing V1 Main Flow & Actions | |||
| Resolved | HNordeenWMF | T390999 Tabs overview | |||
| Resolved | Mazevedo | T392925 Tabs Overview UI - Show current tab when opening overview |
Event Timeline
@Mazevedo
The scrolling is quite intense when I have fewer than 100 tabs. Is there anyway to not show the very fast scrolling to the user and just have it appear once it's at the right position?
Also with 100+ tabs, the performance of loading the tabs overview starts to struggle. I appreciate not having the really fast scroll (video from iPad Mini) https://drive.google.com/file/d/1hl1TGu3aCYVOVXVcoTPq9i0Zqn9Zcqn1/view?usp=sharing
Hi @HNordeenWMF, that's the default SwiftUI behaviour when scrolling to an element in this type of grid (which is an out-of-the-box element). I'm not sure if it's possible to tweak the speed - I can try to add a delay in the order of milliseconds to make it seem slower. However, that'd make the already slow loading with 100+ tabs seem even slower.
As for performance issues, I'm not sure how big the lift to fix this would be, since this is out-of-the-box behaviour. Collection view types are famously bad in performance in iOS since their UIKit version, our app has a lot of custom code created to circumvent this type of issue. So I'm afraid the solution here would be creating custom elements, which I don't believe is worth it at this point.
@HNordeenWMF and @ABorbaWMF we have a new Experimental build out some improvements. I'm scrolling to the current tab before the view loads, so you can see a spinner before the tabs load.
You can test with a lot of tabs to check how it performs.
Wikipedia Experimental 7.7.6 (258)
(Please move back to code review after reviewing this ticket, thanks)
I like the spinner! However now when the current tab is one of the last 3, it's not fully visible on the screen anymore.