Ensure binary input CSS-only components follow current 2.0.0 markup
Open, LowPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Volker_E
	Apr 30 2025, 5:25 AM

Description

Background

The font modes T387778: [breaking change] Font modes: Introduce font modes to Codex make a markup need more visible than before.
Having the label of binary inputs (Checkbox, Radio) feature an extra label text span.
Without it, there is a possible vertical misalignment in those component and label combos.

Goal

Bring markup of all CSS-only binary input to current way.

Implementation

Higher priority

UniversalLanguageSelector. Highly visible.
ExternalGuidance. Used on wikipedias by default.

Lower priority

MW core: HTMLCheckField and HTMLRadioField. The Codex versions of these are not currently used anywhere.
CodexPHP. Not used in production yet.
FlaggedRevs. Warning on the extension page indicates that this is not important to fix quickly. Let's not bother updating it.

Acceptance criteria for done

Unify markup
- MW core: CheckboxField and RadioField
- ExternalGuidance – https://gerrit.wikimedia.org/r/1140540
- UniversalLanguageSelector – https://gerrit.wikimedia.org/r/1139981
- CodexPHP

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update Codex Radio markup	mediawiki/extensions/ExternalGuidance	master	+73 -51
	styles: Unify CSS-only Radio label markup with latest Codex markup	mediawiki/extensions/UniversalLanguageSelector	master	+28 -13

Customize query in gerrit

Related Objects

Mentioned Here: T387778: [breaking change] Font modes: Introduce font modes to Codex

Event Timeline

Volker_E created this task.Apr 30 2025, 5:25 AM

Restricted Application edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-46 (2025-04-28 to 2025-05-09)). · View Herald TranscriptApr 30 2025, 5:25 AM

Change #1139981 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/UniversalLanguageSelector@master] styles: Unify CSS-only Radio label markup with latest Codex markup

https://gerrit.wikimedia.org/r/1139981

gerritbot added a project: Patch-For-Review.Apr 30 2025, 5:55 AM

Volker_E moved this task from Backlog to v2.0.0-rc.1 Release on the Codex 2.0 board.Apr 30 2025, 4:58 PM

Volker_E updated the task description. (Show Details)Apr 30 2025, 5:09 PM

I'm moving this into the sprint since we're working on at least some of the affected repos now. I think we should:

Move forward with the ULS fix that Volker already provided.
Assess the impact of the CodexPHP and HTMLForm issues. Does the outdated markup in these codebases cause the misalignment? If so, where are they used and how many users are affected? This will help us decide if we need to get a fix into these repos now or if it can happen later.

egardner moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-46 (2025-04-28 to 2025-05-09)) board.Apr 30 2025, 9:55 PM

egardner set the point value for this task to 1.

Update: it looks like no one is using the Codex version of the HTMLCheckField or HTMLRadioField so there's no rush to fix the markup for those

AnneT updated the task description. (Show Details)May 1 2025, 5:40 PM

Change #1140540 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/extensions/ExternalGuidance@master] Update Codex Radio markup

https://gerrit.wikimedia.org/r/1140540

Change #1139981 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] styles: Unify CSS-only Radio label markup with latest Codex markup

https://gerrit.wikimedia.org/r/1139981

Volker_E updated the task description. (Show Details)May 5 2025, 6:41 AM

Volker_E updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06).May 5 2025, 7:00 AM

AnneT moved this task from v2.0.0-rc.1 Release to v2.0.0-rc.2 Release on the Codex 2.0 board.May 7 2025, 2:30 PM

AnneT moved this task from Code Review to In Progress on the Design-System-Team (DST-Sprint-46 (2025-04-28 to 2025-05-09)) board.May 7 2025, 2:33 PM

CCiufo-WMF assigned this task to Volker_E.May 12 2025, 4:48 PM

CCiufo-WMF triaged this task as Medium priority.

CCiufo-WMF moved this task from DST-Sprint-46 (2025-04-28 to 2025-05-09) to Up Next on the Design-System-Team board.

CCiufo-WMF edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-46 (2025-04-28 to 2025-05-09)).

CCiufo-WMF changed the point value for this task from 1 to 2.

CCiufo-WMF raised the priority of this task from Medium to High.May 12 2025, 4:56 PM

Volker_E edited projects, added Design-System-Team (DST-Sprint-47 (2025-05-12 to 2025-05-23)); removed Design-System-Team.May 12 2025, 5:06 PM

Change #1140540 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] Update Codex Radio markup

https://gerrit.wikimedia.org/r/1140540

Maintenance_bot removed a project: Patch-For-Review.May 13 2025, 7:30 AM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 13 2025, 8:00 AM

Volker_E updated the task description. (Show Details)May 13 2025, 2:18 PM

CCiufo-WMF moved this task from Committed to Pending Release on the Design-System-Team (DST-Sprint-47 (2025-05-12 to 2025-05-23)) board.May 23 2025, 2:51 PM

egardner closed this task as Resolved.May 23 2025, 10:52 PM

Some of these haven't been done yet; see acceptance criteria

CCiufo-WMF lowered the priority of this task from High to Low.Jun 2 2025, 5:13 PM

CCiufo-WMF removed a project: Codex 2.0.

CCiufo-WMF moved this task from Backlog to Upcoming on the Codex board.

egardner moved this task from Upcoming to Pending Release on the Codex board.Jun 4 2025, 9:24 PM

AnneT moved this task from Pending Release to Ready for Design/Dev on the Codex board.Jun 12 2025, 2:27 PM

egardner closed this task as Resolved.Jun 12 2025, 8:48 PM

egardner moved this task from Ready for Design/Dev to Pending Release on the Codex board.

AnneT reopened this task as Open.Jun 16 2025, 1:46 PM

AnneT updated the task description. (Show Details)Jun 16 2025, 1:49 PM

CCiufo-WMF removed a parent task: T392379: Font modes: test Codex 2.0.0-rc.1 on PatchDemo and beta.Jun 16 2025, 3:22 PM

CCiufo-WMF added a project: Codex 2.0.

CCiufo-WMF moved this task from v2.0.0-rc.2 Release to v2.0.0 Post-release on the Codex 2.0 board.

CCiufo-WMF moved this task from Pending Release to Ready for Design/Dev on the Codex board.Jun 25 2025, 2:58 PM

Ensure binary input CSS-only components follow current 2.0.0 markupOpen, LowPublic2 Estimated Story PointsActions