Page MenuHomePhabricator
Create Task
Maniphest T392982

Improve logging around saving/publishing of translations on CX
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

We've setup a new channel: ContentTranslation to Logstash.

In addition,

  • We should update our code to log all errors related to publishing or saving drafts to this channel
  • Update LPL team dashboard in Logstash to track errors from this channel.
  • Setup a process to review logs pro-actively rather than having users reporting errors. - Team process discussion - to be tracked separately.
  • Decide if we want to allow users to report errors by prefilling fields in Phabricator. - Will be tracked separately.
  • See if alerts can be setup. - Tracked separately T376535: Setup alert for LPL team Grafana dashboards

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix: Avoid logging captcha related errors during SX publishmediawiki/extensions/ContentTranslationmaster+5 -3
Avoid logging captcha related errors during publishmediawiki/extensions/ContentTranslationmaster+20 -14
Avoid logging ApiUsageException on section/page publish APImediawiki/extensions/ContentTranslationmaster+8 -4
Add try...catch around CX/SX save handlermediawiki/extensions/ContentTranslationmaster+46 -40
Add Logstash logging on section/page publish APImediawiki/extensions/ContentTranslationmaster+70 -3
CX Desktop Editor: Scroll to the infobar when displaying messagemediawiki/extensions/ContentTranslationmaster+10 -2
Check if node has isFocusListenerAttached method before callingmediawiki/extensions/ContentTranslationmaster+4 -0
CX: Wrap publish logic around try...catchmediawiki/extensions/ContentTranslationmaster+31 -25
Customize query in gerrit

Related Objects

Event Timeline

abi_ created this task.Apr 30 2025, 7:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2025, 7:24 AM
abi_ mentioned this in T376531: Translated paragraphs disappear in the Content Translation Tool.Apr 30 2025, 7:25 AM
abi_ updated the task description. (Show Details)
abi_ updated the task description. (Show Details)
gerritbot added a comment.May 6 2025, 3:38 PM

Change #1142626 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] CX: Wrap publish logic around try...catch

https://gerrit.wikimedia.org/r/1142626

gerritbot added a project: Patch-For-Review.May 6 2025, 3:38 PM
gerritbot added a comment.May 6 2025, 4:27 PM

Change #1142634 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Check if node has isFocusListenerAttached method before calling

https://gerrit.wikimedia.org/r/1142634

abi_ changed the task status from Open to In Progress.May 6 2025, 4:56 PM
abi_ moved this task from Backlog to In Progress on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.
gerritbot added a comment.May 7 2025, 6:06 PM

Change #1142626 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Wrap publish logic around try...catch

https://gerrit.wikimedia.org/r/1142626

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 7 2025, 7:00 PM
Nikerabbit moved this task from Needs Triage to Enhancements on the ContentTranslation board.May 8 2025, 8:39 AM
gerritbot added a comment.May 12 2025, 10:38 AM

Change #1142634 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Check if node has isFocusListenerAttached method before calling

https://gerrit.wikimedia.org/r/1142634

Maintenance_bot removed a project: Patch-For-Review.May 12 2025, 11:31 AM
gerritbot added a comment.May 12 2025, 12:12 PM

Change #1144525 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] CX Desktop Editor: Scroll to the infobar when displaying message

https://gerrit.wikimedia.org/r/1144525

gerritbot added a project: Patch-For-Review.May 12 2025, 12:12 PM
abi_ added a comment.May 13 2025, 10:48 AM

The ContentTranslation channel in Logstash now has logs: https://logstash.wikimedia.org/goto/2bc83a09dff80dbd5b8b2caabd11d45c

gerritbot added a comment.May 14 2025, 12:00 PM

Change #1144525 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Desktop Editor: Scroll to the infobar when displaying message

https://gerrit.wikimedia.org/r/1144525

Maintenance_bot removed a project: Patch-For-Review.May 14 2025, 12:30 PM
ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20); removed: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 14 2025, 1:00 PM
gerritbot added a comment.May 14 2025, 2:56 PM

Change #1146000 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Add Logstash logging on section/page publish API

https://gerrit.wikimedia.org/r/1146000

gerritbot added a project: Patch-For-Review.May 14 2025, 2:56 PM
gerritbot added a comment.May 15 2025, 1:58 PM

Change #1146632 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Add try...catch around CX/SX save handler

https://gerrit.wikimedia.org/r/1146632

gerritbot added a comment.May 21 2025, 11:50 AM

Change #1146000 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Add Logstash logging on section/page publish API

https://gerrit.wikimedia.org/r/1146000

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 21 2025, 12:00 PM
gerritbot added a comment.May 21 2025, 4:21 PM

Change #1146632 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Add try...catch around CX/SX save handler

https://gerrit.wikimedia.org/r/1146632

Maintenance_bot removed a project: Patch-For-Review.May 21 2025, 4:30 PM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.May 22 2025, 10:11 AM
Nikerabbit moved this task from Pending Deployment to Need QA on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.Jun 2 2025, 6:49 AM
abi_ moved this task from Need QA to In Progress on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.Jun 9 2025, 9:39 AM

I'm noticing a lot of occurrences of Error when publishing section {targetTitle}, {apiException} with the apiException as,

  • ⧼abusefilter-warning-character⧽
  • captcha issues
  • The text you wanted to publish was blocked by our filter. The following domain is blocked from being added: pravda.com.ua

etc

I think all of these issues shouldn't be logged.

gerritbot added a comment.Jun 17 2025, 6:55 AM

Change #1159925 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Avoid logging ApiUsageException on section/page publish API

https://gerrit.wikimedia.org/r/1159925

gerritbot added a project: Patch-For-Review.Jun 17 2025, 6:55 AM
gerritbot added a comment.Jun 17 2025, 10:07 AM

Change #1159925 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Avoid logging ApiUsageException on section/page publish API

https://gerrit.wikimedia.org/r/1159925

Maintenance_bot removed a project: Patch-For-Review.Jun 17 2025, 10:31 AM
ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.7; 2025-06-24); removed: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).Jun 17 2025, 11:00 AM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.Jun 18 2025, 12:55 AM
Nikerabbit moved this task from Pending Deployment to Need QA on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.Jun 30 2025, 6:08 AM
abi_ moved this task from Need QA to In Progress on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.Jul 4 2025, 12:25 PM

I'm still noticing some logs about captcha validation failures. I don't think these are worth logging.

{
    "captcha": {
        "type": "image",
        "mime": "image\/png",
        "id": "1214963447161357499",
        "url": "\/w\/index.php?title=%E7%89%B9%E5%88%A5:%E7%94%BB%E5%83%8F%E8%AA%8D%E8%A8%BC\/image&wpCaptchaId=1214963447161357499"
    },
    "result": "Failure"
}
gerritbot added a comment.Jul 7 2025, 2:09 PM

Change #1166837 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Avoid logging captcha related errors during publish

https://gerrit.wikimedia.org/r/1166837

gerritbot added a project: Patch-For-Review.Jul 7 2025, 2:10 PM
gerritbot added a comment.Jul 7 2025, 2:59 PM

Change #1166837 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Avoid logging captcha related errors during publish

https://gerrit.wikimedia.org/r/1166837

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.9; 2025-07-08); removed: MW-1.45-notes (1.45.0-wmf.7; 2025-06-24).Jul 7 2025, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 7 2025, 3:32 PM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.Jul 7 2025, 4:37 PM
Nikerabbit moved this task from Pending Deployment to In Progress on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.Jul 10 2025, 6:52 AM
Nikerabbit subscribed.

Noticed still errors on wmf.9. Left two comments in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/1166837

Nikerabbit moved this task from Enhancements to Drafts and publishing on the ContentTranslation board.Jul 10 2025, 11:36 AM
gerritbot added a comment.Jul 11 2025, 11:17 AM

Change #1168156 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Fix: Avoid logging captcha related errors during SX publish

https://gerrit.wikimedia.org/r/1168156

gerritbot added a project: Patch-For-Review.Jul 11 2025, 11:17 AM
gerritbot added a comment.Jul 11 2025, 6:44 PM

Change #1168156 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fix: Avoid logging captcha related errors during SX publish

https://gerrit.wikimedia.org/r/1168156

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.10; 2025-07-15); removed: MW-1.45-notes (1.45.0-wmf.9; 2025-07-08).Jul 11 2025, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 11 2025, 7:30 PM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.Jul 12 2025, 9:31 AM
Nikerabbit edited projects, added: LPL Essential (2025 Jul-Oct); removed: LPL Essential (LPL Essential 2025 Apr-Jun: CX).Jul 14 2025, 8:13 AM
Nikerabbit moved this task from Backlog to Pending Deployment on the LPL Essential (2025 Jul-Oct) board.
Nikerabbit added a project: LPL Projects (CX observability).Jul 14 2025, 8:27 AM
abi_ moved this task from Pending Deployment to Need QA on the LPL Essential (2025 Jul-Oct) board.Jul 18 2025, 5:11 AM

All patches deployed. I'll be doing the QA.

abi_ updated the task description. (Show Details)Jul 21 2025, 12:57 PM
abi_ moved this task from Need QA to In Progress on the LPL Essential (2025 Jul-Oct) board.Jul 21 2025, 1:03 PM
In T392982#11015753, @abi_ wrote:

All patches deployed. I'll be doing the QA.

I'm not seeing any spurious errors in the channel.

Next step: Update the LPL Logstash dashboard to show logs from this channel.

abi_ added a comment.Jul 21 2025, 1:08 PM
In T392982#11020211, @abi_ wrote:
In T392982#11015753, @abi_ wrote:

All patches deployed. I'll be doing the QA.

I'm not seeing any spurious errors in the channel.

Next step: Update the LPL Logstash dashboard to show logs from this channel.

I've updated the LPL team dashboard to include logs from the ContentTranslation channel

abi_ updated the task description. (Show Details)Jul 21 2025, 1:08 PM
abi_ changed the task status from In Progress to Open.Jul 21 2025, 1:11 PM
abi_ moved this task from In Progress to Done on the LPL Essential (2025 Jul-Oct) board.

Moving to Done column, but leaving it open for others to verify what's been done.

Nikerabbit closed this task as Resolved.Jul 28 2025, 8:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits