Page MenuHomePhabricator

Raster thumbnail info shown for SVG files that don't have raster thumbnails
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Set $wgSVGNativeRendering to true
  • Go to the file page of any SVG file on your wiki

What happens?:
Below the preview, there is a line of text similar to this:

image.png (948×18 px, 7 KB)

It states that the preview is a PNG and contains multiple links to thumbnails in various sizes. All of the links point to the static url of the svg file, therefore having no use.

What should have happened instead?:
No size options should be shown since no raster/PNG thumbnails are being generated.
Additionally, it shouldn't be stated that a PNG preview is shown, because there isn't. The preview uses native SVG rendering.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Tested on 1.44.0-alpha (6bfb8fa) and 1.43.1 (cde4276)
Other information (browser name/version, screenshots, etc.):
Miraheze task where this was initially reported: https://issue-tracker.miraheze.org/T13486

Event Timeline

Change #1173936 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] ImagePage: Remove PNG previews line for native SVG rendering

https://gerrit.wikimedia.org/r/1173936

Change #1173936 merged by jenkins-bot:

[mediawiki/core@master] ImagePage: Remove PNG previews line for native SVG rendering

https://gerrit.wikimedia.org/r/1173936

Change #1174548 had a related patch set uploaded (by SomeRandomDeveloper; author: TheDJ):

[mediawiki/core@REL1_44] ImagePage: Remove PNG previews line for native SVG rendering

https://gerrit.wikimedia.org/r/1174548

Change #1174555 had a related patch set uploaded (by SomeRandomDeveloper; author: TheDJ):

[mediawiki/core@REL1_43] ImagePage: Remove PNG previews line for native SVG rendering

https://gerrit.wikimedia.org/r/1174555

Change #1174555 merged by jenkins-bot:

[mediawiki/core@REL1_43] ImagePage: Remove PNG previews line for native SVG rendering

https://gerrit.wikimedia.org/r/1174555

Change #1174548 merged by jenkins-bot:

[mediawiki/core@REL1_44] ImagePage: Remove PNG previews line for native SVG rendering

https://gerrit.wikimedia.org/r/1174548