Make PHPUnit dataProvider static in CommunityConfiguration tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 1 2025, 4:46 AM

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

static and adjust the usages (More infos at T332865).

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	tests: Remove unused function from EditorCapabilityFactoryTest	mediawiki/extensions/CommunityConfiguration	master	+13 -21

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Stalled	None	T334726 Use return type `never` in Wikibase
Open	None	T232915 Red-green in PHPUnit code coverage are hard to read
Open	None	T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T332865 PHPUnit data providers should be simple static functions that return plain data
Resolved	Umherirrender	T393079 Make PHPUnit dataProvider static in CommunityConfiguration tests

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Urbanecm_WMF Do you have any thoughts on this?

Change #1143161 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CommunityConfiguration@master] tests: Remove unused function from EditorCapabilityFactoryTest

Change #1143161 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] tests: Remove unused function from EditorCapabilityFactoryTest