Make PHPUnit dataProvider static in AutoModerator tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 1 2025, 4:49 AM

Project Tags

Referenced Files

None

Subscribers

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

ORESRecentChangeScoreSavedHookHandlerTest with provideOnOresRecentChangesScoreSavedQueued, provideOnOresRecentChangesScoreSavedNotQueued
RevisionFromEditCompleteHookHandlerTest with provideOnRevisionFromEditCompleteQueued, provideOnRevisionFromEditCompleteQueuedTalkPageMessageJob, provideOnRevisionFromEditCompleteMainNotQueued, provideOnRevisionFromEditCompleteTalkNotQueued
RollbackCompleteHookHandlerTest with provideOnRollbackComplete

static and adjust the usages (More infos at T332865).

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	tests: Make PHPUnit data provider static	Umherirrender	mediawiki/extensions/AutoModerator	master	+264 -124
	tests: Make PHPUnit data provider static	Umherirrender	mediawiki/extensions/AutoModerator	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Stalled	None	T334726 Use return type `never` in Wikibase
Open	None	T232915 Red-green in PHPUnit code coverage are hard to read
Open	None	T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T332865 PHPUnit data providers should be simple static functions that return plain data
Resolved	Umherirrender	T393080 Make PHPUnit dataProvider static in AutoModerator tests

Event Timeline

Umherirrender created this task.May 1 2025, 4:49 AM

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMay 1 2025, 4:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 1 2025, 4:49 AM

Change #1140279 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AutoModerator@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140279

gerritbot added a project: Patch-For-Review.May 1 2025, 4:59 AM

• Scardenasmolinar edited projects, added: Moderator-Tools-Team (Kanban); removed: Moderator-Tools-Team.May 1 2025, 5:04 PM

• Scardenasmolinar moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.

Change #1140279 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140279

Umherirrender mentioned this in rEAMOa0a03d560870: tests: Make PHPUnit data provider static.May 1 2025, 6:36 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06).May 1 2025, 7:00 PM

Moving this back to ready since there's a few more we need to update.

Maintenance_bot removed a project: Patch-For-Review.May 1 2025, 7:30 PM

• Scardenasmolinar moved this task from Ready (Maintenance) to Done on the Moderator-Tools-Team (Kanban) board.May 2 2025, 3:08 AM

existing patch looks good, resetting to in progress so we can catch the other occurrences.

• Scardenasmolinar changed the task status from Open to In Progress.May 5 2025, 5:18 PM

• Scardenasmolinar claimed this task.

• Scardenasmolinar triaged this task as Low priority.May 7 2025, 12:11 AM

Change #1143158 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AutoModerator@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1143158

gerritbot added a project: Patch-For-Review.May 7 2025, 6:31 PM

Created a patch set to move the mocks into it's test function as a "quick win" (as this is only low priority and maybe fall out some day of the work queue)