The @dataProvider annotation should be a static function, make
- AbstractChangesListSpecialPageTestCase::provideParseParameters
- AbstractChangesListSpecialPageTestCase::validateOptionsProvider
static and adjust the usages (More infos at T332865).
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| tests: Make PHPUnit data provider for ChangesListSpecialPage static | mediawiki/core | master | +6 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | None | T255792 Quibble runs core:unit tests twice! | |||
| Stalled | None | T334726 Use return type `never` in Wikibase | |||
| Open | None | T232915 Red-green in PHPUnit code coverage are hard to read | |||
| Open | None | T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10 | |||
| Open | None | T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min | |||
| Open | None | T332865 PHPUnit data providers should be simple static functions that return plain data | |||
| Resolved | Umherirrender | T393081 Make PHPUnit dataProvider on AbstractChangesListSpecialPageTestCase static |
Event Timeline
Comment Actions
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Comment Actions
Change #1143164 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] tests: Make PHPUnit data provider for ChangesListSpecialPage static
Comment Actions
Change #1143164 merged by jenkins-bot:
[mediawiki/core@master] tests: Make PHPUnit data provider for ChangesListSpecialPage static