Page MenuHomePhabricator

Make PHPUnit dataProvider on OutputTransformStageTestBase static
Closed, ResolvedPublic

Description

The @dataProvider annotation should be a static function, make

  • OutputTransformStageTestBase::provideShouldRun
  • OutputTransformStageTestBase::provideShouldNotRun
  • OutputTransformStageTestBase::provideTransform

static and adjust the usages (More infos at T332865).

Event Timeline

Change #1147112 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Make PHPUnit data provider static in OutputTransformStageTestBase

https://gerrit.wikimedia.org/r/1147112

Change #1147112 merged by jenkins-bot:

[mediawiki/core@master] tests: Make PHPUnit data provider static in OutputTransformStageTestBase

https://gerrit.wikimedia.org/r/1147112