Page MenuHomePhabricator

Make PHPUnit dataProvider on TypeDefTestCaseTrait static
Closed, ResolvedPublic

Description

The @dataProvider annotation should be a static function, make

  • TypeDefTestCaseTrait::provideValidate
  • TypeDefTestCaseTrait::provideNormalizeSettings
  • TypeDefTestCaseTrait::provideCheckSettings
  • TypeDefTestCaseTrait::provideGetEnumValues
  • TypeDefTestCaseTrait::provideStringifyValue
  • TypeDefTestCaseTrait::provideGetInfo

static and adjust the usages (More infos at T332865).

Event Timeline

Change #1147042 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Make PHPUnit data provider static in TypeDefTestCaseTrait

https://gerrit.wikimedia.org/r/1147042

Change #1147042 merged by jenkins-bot:

[mediawiki/core@master] tests: Make PHPUnit data provider static in TypeDefTestCaseTrait

https://gerrit.wikimedia.org/r/1147042