Make PHPUnit dataProvider on PasswordTestCase static
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 1 2025, 6:45 PM

Description

The @dataProvider annotation should be a static function, make

static and adjust the usages (More infos at T332865).

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	password: Convert PasswordTestCase helpers to static methods	mediawiki/core	master	+15 -17

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Stalled	None	T334726 Use return type `never` in Wikibase
Open	None	T232915 Red-green in PHPUnit code coverage are hard to read
Open	None	T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T332865 PHPUnit data providers should be simple static functions that return plain data
Resolved	• mszabo	T393115 Make PHPUnit dataProvider on PasswordTestCase static

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2025, 6:45 PM

Change #1144594 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] password: Convert PasswordTestCase helpers to static methods

Change #1144594 merged by jenkins-bot:

[mediawiki/core@master] password: Convert PasswordTestCase helpers to static methods