Page MenuHomePhabricator
Create Task
Maniphest T393122

Make PHPUnit dataProvider on BundleSizeTestBase static
Closed, ResolvedPublic
Actions

Description

The @dataProvider annotation should be a static function, make

  • BundleSizeTestBase::provideBundleSize

static and adjust the usages (More infos at T332865).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Merge remote-tracking branch 'origin/master' into wmf_deploymediawiki/extensions/CentralNoticewmf/1.45.0-wmf.1+46 -9
Make BundleSizeTest cross-compatible with <=1.44 and >=1.45mediawiki/extensions/CentralNoticewmf/1.45.0-wmf.1+9 -1
Make BundleSizeTest cross-compatible with <=1.44 and >=1.45mediawiki/extensions/CentralNoticemaster+8 -0
Make BundleSizeTest cross-compatible with <=1.44 and >=1.45mediawiki/extensions/BlueSpiceFoundationmaster+9 -1
Merge remote-tracking branch 'origin/master' into wmf_deploymediawiki/extensions/CentralNoticewmf_deploy+0 -0
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/CentralNoticemaster+1 -1
tests: Use new static `getBundleSizeConfigData` method (part 2)mediawiki/coremaster+3 -35
tests: Migrate bundle size consumers to the new static methodmediawiki/skins/MinervaNeuemaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/Popupsmaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/RelatedArticlesmaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/ContentTranslationmaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/skins/Vectormaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/GrowthExperimentsmaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/CheckUsermaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/Wikibasemaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/UniversalLanguageSelectormaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/MobileFrontendmaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/MultimediaViewermaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/NavigationTimingmaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/Echomaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/Chartmaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/EventLoggingmaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/WikimediaEventsmaster+1 -1
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/WikimediaMessagesmaster+1 -1
tests: BundleSizeTestBase::provideBundleSize should be static (part 1)mediawiki/coremaster+37 -3
tests: Migrate bundle size consumers to the new static methodmediawiki/extensions/FlaggedRevsmaster+1 -1
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.May 1 2025, 8:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2025, 8:10 PM
Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 1 2025, 8:10 PM
gerritbot added a comment.May 2 2025, 1:14 PM

Change #1140705 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] tests: BundleSizeTestBase::provideBundleSize should be static

https://gerrit.wikimedia.org/r/1140705

gerritbot added a project: Patch-For-Review.May 2 2025, 1:14 PM
xSavitar claimed this task.May 2 2025, 1:15 PM
Restricted Application added a project: User-xSavitar. · View Herald TranscriptMay 2 2025, 1:15 PM
gerritbot added a comment.May 7 2025, 10:22 AM

Change #1143030 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Chart@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143030

gerritbot added a comment.May 7 2025, 10:22 AM

Change #1143031 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/CheckUser@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143031

gerritbot added a comment.May 7 2025, 10:22 AM

Change #1143032 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/ContentTranslation@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143032

gerritbot added a comment.May 7 2025, 10:22 AM

Change #1143033 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Echo@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143033

gerritbot added a comment.May 7 2025, 10:22 AM

Change #1143034 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/EventLogging@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143034

gerritbot added a comment.May 7 2025, 10:22 AM

Change #1143035 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/FlaggedRevs@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143035

gerritbot added a comment.May 7 2025, 10:23 AM

Change #1143036 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/GrowthExperiments@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143036

gerritbot added a comment.May 7 2025, 10:23 AM

Change #1143037 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/MobileFrontend@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143037

gerritbot added a comment.May 7 2025, 10:23 AM

Change #1143038 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/MultimediaViewer@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143038

gerritbot added a comment.May 7 2025, 10:23 AM

Change #1143039 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/NavigationTiming@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143039

gerritbot added a comment.May 7 2025, 10:23 AM

Change #1143040 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Popups@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143040

gerritbot added a comment.May 7 2025, 10:23 AM

Change #1143041 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/RelatedArticles@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143041

gerritbot added a comment.May 7 2025, 10:23 AM

Change #1143042 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/UniversalLanguageSelector@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143042

gerritbot added a comment.May 7 2025, 10:23 AM

Change #1143043 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Wikibase@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143043

gerritbot added a comment.May 7 2025, 10:23 AM

Change #1143044 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/WikimediaEvents@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143044

gerritbot added a comment.May 7 2025, 10:23 AM

Change #1143045 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/WikimediaMessages@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143045

gerritbot added a comment.May 7 2025, 10:24 AM

Change #1143046 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/skins/MinervaNeue@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143046

gerritbot added a comment.May 7 2025, 10:24 AM

Change #1143047 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/skins/Vector@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143047

gerritbot added a comment.May 7 2025, 12:11 PM

Change #1143071 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] tests: Use new static `getBundleSizeConfigData` method (part 2)

https://gerrit.wikimedia.org/r/1143071

gerritbot added a comment.May 8 2025, 3:21 PM

Change #1140705 merged by jenkins-bot:

[mediawiki/core@master] tests: BundleSizeTestBase::provideBundleSize should be static (part 1)

https://gerrit.wikimedia.org/r/1140705

gerritbot added a comment.May 8 2025, 3:21 PM

Change #1143035 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143035

gerritbot added a comment.May 8 2025, 3:21 PM

Change #1143044 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143044

gerritbot added a comment.May 8 2025, 3:22 PM

Change #1143045 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143045

gerritbot added a comment.May 8 2025, 3:33 PM

Change #1143033 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143033

gerritbot added a comment.May 8 2025, 3:33 PM

Change #1143034 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143034

gerritbot added a comment.May 8 2025, 3:41 PM

Change #1143030 merged by jenkins-bot:

[mediawiki/extensions/Chart@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143030

DAlangi_WMF mentioned this in rECRTdd3d6814400b: tests: Migrate bundle size consumers to the new static method.May 8 2025, 3:42 PM
gerritbot added a comment.May 8 2025, 3:49 PM

Change #1143038 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143038

gerritbot added a comment.May 8 2025, 3:49 PM

Change #1143039 merged by jenkins-bot:

[mediawiki/extensions/NavigationTiming@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143039

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 8 2025, 4:00 PM
gerritbot added a comment.May 8 2025, 4:19 PM

Change #1143037 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143037

gerritbot added a comment.May 8 2025, 4:19 PM

Change #1143042 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143042

gerritbot added a comment.May 8 2025, 4:46 PM

Change #1143043 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143043

gerritbot added a comment.May 8 2025, 4:46 PM

Change #1143036 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143036

gerritbot added a comment.May 8 2025, 4:46 PM

Change #1143031 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143031

gerritbot added a comment.May 8 2025, 5:14 PM

Change #1143032 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143032

gerritbot added a comment.May 8 2025, 5:18 PM

Change #1143047 merged by jenkins-bot:

[mediawiki/skins/Vector@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143047

gerritbot added a comment.May 8 2025, 5:27 PM

Change #1143046 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143046

gerritbot added a comment.May 8 2025, 5:27 PM

Change #1143041 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143041

gerritbot added a comment.May 8 2025, 5:27 PM

Change #1143040 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1143040

matmarex subscribed.May 8 2025, 7:41 PM
gerritbot added a comment.May 8 2025, 7:59 PM

Change #1143071 merged by jenkins-bot:

[mediawiki/core@master] tests: Use new static `getBundleSizeConfigData` method (part 2)

https://gerrit.wikimedia.org/r/1143071

matmarex closed this task as Resolved.May 8 2025, 8:10 PM
Maintenance_bot removed a project: Patch-For-Review.May 8 2025, 8:30 PM
gerritbot added a comment.May 15 2025, 1:33 PM

Change #1146625 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/CentralNotice@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1146625

gerritbot added a project: Patch-For-Review.May 15 2025, 1:33 PM
gerritbot added a comment.May 15 2025, 1:47 PM

Change #1146625 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1146625

gerritbot added a comment.May 15 2025, 1:53 PM

Change #1143609 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1143609

gerritbot added a comment.May 15 2025, 1:55 PM

Change #1143609 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1143609

gerritbot added a comment.May 15 2025, 1:57 PM

Change #1146631 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1146631

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.2; 2025-05-20); removed MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 15 2025, 2:00 PM
gerritbot added a comment.May 16 2025, 9:08 AM

Change #1146937 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/BlueSpiceFoundation@master] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45

https://gerrit.wikimedia.org/r/1146937

gerritbot added a comment.May 16 2025, 9:25 AM

Change #1146937 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceFoundation@master] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45

https://gerrit.wikimedia.org/r/1146937

Reedy mentioned this in T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .May 16 2025, 6:56 PM
gerritbot added a comment.May 19 2025, 6:31 PM

Change #1147839 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45

https://gerrit.wikimedia.org/r/1147839

gerritbot added a comment.May 20 2025, 12:21 AM

Change #1147839 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45

https://gerrit.wikimedia.org/r/1147839

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.1; 2025-05-13); removed MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 20 2025, 1:00 AM
gerritbot added a comment.May 20 2025, 1:25 AM

Change #1147910 had a related patch set uploaded (by Ejegg; author: Jgleeson):

[mediawiki/extensions/CentralNotice@master] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45

https://gerrit.wikimedia.org/r/1147910

gerritbot added a comment.May 20 2025, 1:33 AM

Change #1147910 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45

https://gerrit.wikimedia.org/r/1147910

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 20 2025, 2:00 AM
gerritbot added a comment.May 20 2025, 8:54 PM

Change #1146631 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1146631

Stashbot mentioned this in T394270: LogicException: Title not found!.May 20 2025, 8:55 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-20T20:55:02Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]]

Stashbot mentioned this in T394025: PHP Deprecated: Use of MediaWiki\Xml\Xml::input was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::inputLabelSep].May 20 2025, 8:55 PM
Stashbot mentioned this in T341775: Discourage, deprecate and stop using Xml methods for building HTML markup.
Stashbot mentioned this in T373017: CI PerformanceBudgetTest fails on GrowthExperiments master branch with 0.5kB difference.
Stashbot mentioned this in T394404: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher].
Stashbot added a comment.May 20 2025, 8:57 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-20T20:57:41Z] <jforrester@deploy1003> mszabo, jforrester: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes c

Stashbot added a comment.May 20 2025, 9:06 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-20T21:06:31Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]] (duration: 11m 28s)

Maintenance_bot removed a project: Patch-For-Review.May 20 2025, 9:30 PM
gerritbot added a comment.Jun 6 2025, 10:24 AM

Change #1154264 had a related patch set uploaded (by Hslater; author: Hslater):

[mediawiki/extensions/BlueSpiceDistributionConnector@master] tests: Migrate bundle size consumers to the new static method

https://gerrit.wikimedia.org/r/1154264

gerritbot added a project: Patch-For-Review.Jun 6 2025, 10:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits