Page MenuHomePhabricator
Create Task
Maniphest T393163

Copy align and text-align and valign and vertical-align when inserting a new row
Closed, ResolvedPublic
Actions

Description

When editing a table where some columns are left/center/right aligned, currently a newly created row does not obtain any of this alignment. Let's copy it from the row cells above.

We want to support the following variants:

<td align="right"></td>
<td style="text-align: right"></td>
<tr align="right"></tr>
<tr style="text-align: right"></tr>

<td valign="top"></td>
<td style="vertical-align: top"></td>
<tr valign="top"></tr>
<tr style="vertical-align: top"></tr>

Note: align and valign are deprecated DOM attributes, but still widely used in Wikipedia articles.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (663f766db)mediawiki/extensions/VisualEditormaster+1 -1
Copy valign and vertical-align when inserting a new rowVisualEditor/VisualEditormaster+42 -6
Copy align and text-align to <tr> when inserting a new rowVisualEditor/VisualEditormaster+125 -40
Copy align and text-align when inserting a new rowVisualEditor/VisualEditormaster+241 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

simon04 created this task.May 2 2025, 9:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2025, 9:59 AM
gerritbot added a comment.May 2 2025, 10:11 AM

Change #1140662 had a related patch set uploaded (by Simon04; author: Simon04):

[VisualEditor/VisualEditor@master] Copy align and text-align when inserting a new row

https://gerrit.wikimedia.org/r/1140662

gerritbot added a project: Patch-For-Review.May 2 2025, 10:11 AM
Esanders added a comment.EditedMay 2 2025, 11:25 AM

I think there's another case when a table consists of a header row followed by data rows. I can imagine in these cases the header row has different styles to the data row. If clicked on the header row and did insertBelow, would I want to clone styles from the data row (as the new row will be a data row)? What if I wanted to add a second header row?

Actually we create a header row when you do this, so copying styles from the header is fine.

simon04 added a parent task: T103276: Provide a way to align/justify the contents of a table cell.May 2 2025, 2:07 PM
gerritbot added a comment.May 2 2025, 3:28 PM

Change #1140662 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Copy align and text-align when inserting a new row

https://gerrit.wikimedia.org/r/1140662

Maintenance_bot removed a project: Patch-For-Review.May 2 2025, 3:30 PM
simon04 updated the task description. (Show Details)May 2 2025, 6:53 PM
gerritbot added a comment.May 2 2025, 6:54 PM

Change #1140750 had a related patch set uploaded (by Simon04; author: Simon04):

[VisualEditor/VisualEditor@master] Copy align and text-align to <tr> when inserting a new row

https://gerrit.wikimedia.org/r/1140750

gerritbot added a project: Patch-For-Review.May 2 2025, 6:54 PM
gerritbot added a comment.May 3 2025, 6:54 AM

Change #1140980 had a related patch set uploaded (by Simon04; author: Simon04):

[VisualEditor/VisualEditor@master] Copy valign and vertical-align when inserting a new row

https://gerrit.wikimedia.org/r/1140980

simon04 added a project: VisualEditor-Tables.May 3 2025, 7:22 AM
gerritbot added a comment.May 3 2025, 9:24 AM

Change #1140750 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Copy align and text-align to <tr> when inserting a new row

https://gerrit.wikimedia.org/r/1140750

gerritbot added a comment.May 3 2025, 11:46 AM

Change #1140980 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Copy valign and vertical-align when inserting a new row

https://gerrit.wikimedia.org/r/1140980

Maintenance_bot removed a project: Patch-For-Review.May 3 2025, 12:30 PM
gerritbot added a comment.May 3 2025, 1:31 PM

Change #1141120 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (663f766db)

https://gerrit.wikimedia.org/r/1141120

gerritbot added a project: Patch-For-Review.May 3 2025, 1:31 PM
gerritbot added a comment.May 3 2025, 2:50 PM

Change #1141120 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (663f766db)

https://gerrit.wikimedia.org/r/1141120

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06).May 3 2025, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 3 2025, 3:30 PM
simon04 renamed this task from Copy align and text-align when inserting a new row to Copy align and text-align and valign and vertical-align when inserting a new row.May 4 2025, 6:13 AM
simon04 updated the task description. (Show Details)
• debt mentioned this in T391688: [Session] 🥳 Wikimedia Hackathon 2025 Project Showcase / Closing Session.May 7 2025, 11:53 AM
simon04 closed this task as Resolved.Jun 10 2025, 4:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits