Page MenuHomePhabricator
Create Task
Maniphest T393179

Make webdriver.io screenshot handling safer
Closed, ResolvedPublic
Actions

Description

Lets see if we can make the screenshot handling for webdriver.io safer e.g do not take screenshots if the browser/tab is broken.

Also try to simplify the code.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
selenium: Do not hide screenshots errorsmediawiki/coremaster+8 -0
selenium: Update mkdir code to be more modernmediawiki/coremaster+5 -9
selenium: Update mkdir code to be more modern.mediawiki/coremaster+5 -9
Customize query in gerrit

Event Timeline

Peter created this task.May 2 2025, 1:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2025, 1:46 PM
gerritbot added a comment.May 2 2025, 1:47 PM

Change #1140712 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Update mkdir code to be more modern.

https://gerrit.wikimedia.org/r/1140712

gerritbot added a project: Patch-For-Review.May 2 2025, 1:47 PM

Change #1140712 abandoned by Phedenskog:

[mediawiki/core@master] selenium: Update mkdir code to be more modern.

Reason:

Let me close it and redo it better

https://gerrit.wikimedia.org/r/1140712

gerritbot added a comment.May 2 2025, 1:52 PM

Change #1140714 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Update mkdir code to be more modern.

https://gerrit.wikimedia.org/r/1140714

zeljkofilipin added projects: Test Platform (kvina 5), User-zeljkofilipin.May 6 2025, 3:50 PM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin subscribed.
SDunlap moved this task from kvina 5 to sesa 6 on the Test Platform board.May 12 2025, 1:35 PM
SDunlap edited projects, added Test Platform (sesa 6); removed Test Platform (kvina 5).
zeljkofilipin moved this task from Backlog to Finishing touches on the Test Platform (sesa 6) board.May 15 2025, 10:56 AM
gerritbot added a comment.May 15 2025, 11:16 AM

Change #1140714 merged by jenkins-bot:

[mediawiki/core@master] selenium: Update mkdir code to be more modern

https://gerrit.wikimedia.org/r/1140714

Maintenance_bot removed a project: Patch-For-Review.May 15 2025, 11:31 AM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 15 2025, 12:00 PM
zeljkofilipin closed this task as Resolved.May 15 2025, 2:53 PM

All commits are merged. Please reopen if there is still something left to do here.

gerritbot added a comment.May 21 2025, 3:05 AM

Change #1147006 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Do not hide screenshots errors

https://gerrit.wikimedia.org/r/1147006

gerritbot added a project: Patch-For-Review.May 21 2025, 3:05 AM
zeljkofilipin reopened this task as Open.May 21 2025, 12:22 PM
gerritbot added a comment.May 21 2025, 1:02 PM

Change #1147006 abandoned by Phedenskog:

[mediawiki/core@master] selenium: Do not hide screenshots errors

Reason:

This happens afterTest so failure here will not fail the test.

https://gerrit.wikimedia.org/r/1147006

zeljkofilipin closed this task as Resolved.May 21 2025, 1:06 PM
Maintenance_bot removed a project: Patch-For-Review.May 21 2025, 1:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits