The example docker compose manifest found on the docker hub page for the official mediawiki image (which appears to be sourced from here) differs significantly from the manifest found in mediawiki/core.
Unless there is a good reason to maintain different versions, I think it would be good to de-duplicate somehow, either by mentioning/linking to the manifest in mediawiki/core or automatically propagating changes from core to docker hub.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | None | T393193 docker-compose.yml in standard package refers to absent DEVELOPERS.md | |||
| Resolved | Douginamug | T393183 Remove docker-compose.yml from MediaWiki archive releases | |||
| Resolved | Douginamug | T393171 Example `docker-compose.yml` gives warning about obsolete `version` attribute |
I had a chat with @Novem_Linguae about this, and he made the pragmatic suggestion to just copy the docker-compose.yml from core to docker hub. On top of this, I would add a comment that "this example may be out of date, and you should check <link> for up-to-date".
I will see if there is anything else that can be improved with the core docker-compose.yml before attempting to edit docker hub, which appears to require action from docker side which may take a while.
The Docker Hub image (Docker-Hub-MediaWiki) is a separate effort from the docker-compose.yml environment provided in mediawiki/core (MediaWiki-Docker), which runs (by default) on images defined in the dev-images project. These aren't expected to be the same, and the Docker Hub images aren't really "official" in a strong sense.
This has caused confusion in the past. Among other things, naming is hard and our ecosystem is worse at it than most. I think it'd probably be worth submitting a PR for the README that clarifies the differences somewhere near the top.
Thanks @brennen for confirming my suspicions. On this basis, I would say the best option would in fact be to remove docker-compose.yml from the bundling process alongside DEVELOPERS.md. Do you know how that process works?
Change #1142955 had a related patch set uploaded (by Douginamug; author: Douginamug):
[mediawiki/core@master] .gitattriutes: add docker-compose.yml to export-ignore
Change #1143571 had a related patch set uploaded (by Majavah; author: Douginamug):
[mediawiki/core@REL1_44] .gitattributes: add docker-compose.yml to export-ignore
Change #1142955 merged by jenkins-bot:
[mediawiki/core@master] .gitattributes: add docker-compose.yml to export-ignore
This has been merged! Thanks for the advice, support and review: it made my first contribution experience really nice and encourages me to do more ☺️
Change #1143571 merged by jenkins-bot:
[mediawiki/core@REL1_44] .gitattributes: add docker-compose.yml to export-ignore
@Jdforrester-WMF I realise now that this change reversed your last commit to .gitattributes https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+log/HEAD/.gitattributes I'm sorry I didn't see that earlier and include you in this ticket. What are your thoughts?